Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1606193003: [parser cleanup] Small cleanups to ParsePropertyName (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser cleanup] Small cleanups to ParsePropertyName Remove an unnecessary is_static argument to ParsePropertyName (the caller already has easy access to that information) and inline ParseIdentifierNameOrGetOrSet into its only caller. Committed: https://crrev.com/e7fdf5eaedf506801f5246296a4f708f8f547ee5 Cr-Commit-Position: refs/heads/master@{#33419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M src/parsing/parser-base.h View 8 chunks +10 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
This is the patch I was originally working on when I found the escaped property ...
4 years, 11 months ago (2016-01-20 20:36:22 UTC) #2
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-20 20:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606193003/1
4 years, 11 months ago (2016-01-20 21:05:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 21:27:38 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 21:27:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7fdf5eaedf506801f5246296a4f708f8f547ee5
Cr-Commit-Position: refs/heads/master@{#33419}

Powered by Google App Engine
This is Rietveld 408576698