third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-slot.html - Issue 1606153002: Implement v1 slot logic in EventPath

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/event-path-with-slot.html

Issue 1606153002: Implement v1 slot logic in EventPath (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove an unintended change Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="resources/shadow-dom.js"></script>

	5 <div id='host'>

	6 <img id="img" src="../../images/resources/test-load.jpg" slot='slot-1'>
	kochi 2016/01/20 09:22:07 nit: please use single quote and double quote cons nit: please use single quote and double quote consistently within a file. For this html, all attribute values should be quoted by double quotes, and in JavaScript code strings should be quoted by single quotes. yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > nit: please use single quote and double quote consistently within a file. > > For this html, all attribute values should be quoted by double quotes, > and in JavaScript code strings should be quoted by single quotes. Done.
	7 <template data-mode='open'>

	8 <slot name='slot-1'></slot>

	9 </template>

	10 </div>

	11

	12 <div id='host2'>

	13 <img id="img2" src="../../images/resources/lenna.jpg" slot='slot-2'>

	14 <template data-mode='open'>

	15 <div id='host3'>

	16 <div id='slot-2-parent'>

	17 <slot name='slot-2'></slot>

	18 </div>

	19 <template data-mode='v0'>

	20 <content select='#slot-2-parent'></content>

	21 </template>

	22 </div>

	23 </template>

	24 </div>

	25 <script>

	26

	27 var host = document.getElementById('host');

	28 convertTemplatesToShadowRootsWithin(host);

	29 removeWhiteSpaceOnlyTextNodes(host);

	30 document.body.offsetLeft;

	31

	32 var img = document.getElementById('img');
	kochi 2016/01/20 09:22:07 Loading an image will make this test slower. For e Loading an image will make this test slower. For example, <input> can substitute this, and use input.focus() to dispatch focus event, then handle onfocus event. yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > Loading an image will make this test slower. > For example, <input> can substitute this, and use input.focus() to > dispatch focus event, then handle onfocus event. Done.
	33 var slot = host.shadowRoot.querySelector('slot');

	34 var shadowRoot = host.shadowRoot;

	35 var expected_array;

	36

	37 img.onload = function(e) {

	38 expected_array = [img, slot, shadowRoot, host, document.body, document.documen tElement, document];
	kochi 2016/01/20 09:22:07 I thought the last element in event.path would be I thought the last element in event.path would be window. Could you check? kochi 2016/01/20 09:39:05 I was told that "load" event is a special case tha Show quoted text On 2016/01/20 09:22:07, kochi wrote: > I thought the last element in event.path would be window. > Could you check? I was told that "load" event is a special case that the event path stops at document and does not reach window. Probably if you change the event type to something else, you will see window at the end of the array. yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:39:05, kochi wrote: > On 2016/01/20 09:22:07, kochi wrote: > > I thought the last element in event.path would be window. > > Could you check? > > I was told that "load" event is a special case that the event path stops > at document and does not reach window. > > Probably if you change the event type to something else, you will see window > at the end of the array. Done. yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > I thought the last element in event.path would be window. > Could you check? Done.
	39 test(function() {

	40 assert_array_equals(e.path, expected_array);

	41 }, "Triggered in a slotted element, eventPath should go through shadow tree.") ;

	42 };

	43

	44 var img2 = document.getElementById('img2');
	kochi 2016/01/20 09:22:07 Same as above, could you avoid using <img>? Same as above, could you avoid using <img>? yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > Same as above, could you avoid using <img>? Done.
	45 var host2 = document.getElementById('host2');

	46 convertTemplatesToShadowRootsWithin(host2);

	47 var srv1 = host2.shadowRoot;
	kochi 2016/01/20 09:22:07 nit: as other ids are not abbreviated, could this nit: as other ids are not abbreviated, could this and "srv0" below be shadowRootV0 and shadowRootV1 for consistency? yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > nit: as other ids are not abbreviated, could this and "srv0" below be > shadowRootV0 and shadowRootV1 for consistency? Done.
	48 var host3 = srv1.querySelector('#host3');

	49 convertTemplatesToShadowRootsWithin(host3);

	50 var slotParent = host3.querySelector('div');

	51 var slot2 = host3.querySelector('slot');

	52 var srv0 = host3.shadowRoot;

	53 var content = srv0.querySelector('content');

	54

	55 img2.onload = function(e) {

	56 expected_array = [img2, slot2, slotParent, content, srv0, host3, srv1, host2, document.body, document.documentElement, document];
	kochi 2016/01/20 09:22:07 Same as above, could you check if the path ends in Same as above, could you check if the path ends in document, not in window? yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > Same as above, could you check if the path ends in document, not in window? Done.
	57 test(function() {

	58 assert_array_equals(e.path, expected_array);

	59 }, "EventPath works fine with v0 insertion points & v1 slots.");

	60 };

	61
	kochi 2016/01/20 09:22:07 Could you also add a test that original event targ Could you also add a test that original event target is not the directly slotted element, but a descendant element of the slotted element? e.g. <div id="host"> #shadow-root <slot> <div> <input> </div> </div> => [input, div, slot, #shadow-root, div#host, ...] yuzuchan 2016/01/20 11:07:50 Done. Show quoted text On 2016/01/20 09:22:07, kochi wrote: > Could you also add a test that original event target is not the directly slotted > element, but a descendant element of the slotted element? > > e.g. > > <div id="host"> > #shadow-root > <slot> > <div> > <input> > </div> > </div> > > => [input, div, slot, #shadow-root, div#host, ...] Done.
	62 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/events/EventPath.cpp » ('j') | no next file with comments »