Issue 160613003: Fixed issue with applying tls_edit in windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160613003: Fixed issue with applying tls_edit in windows (Closed)

Created:
6 years, 10 months ago by David Yen

Modified:
6 years, 10 months ago

Reviewers:
Mark Seaborn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Fixed issue with applying tls_edit in windows Now that build_nexe.py is in charge of applying tls_edit to IRT Nexe's, we need to make sure the command is normalized for the platform. R=mseaborn@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3126 TRY= trybots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12752

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/build_nexe.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

Please set BUG= to the appropriate issue. Then LGTM.

6 years, 10 months ago (2014-02-12 19:15:37 UTC) #2

David Yen

Committed patchset #1 manually as r12752 (presubmit successful).

6 years, 10 months ago (2014-02-12 20:50:16 UTC) #3

Mark Seaborn

For the record, this should have: BUG=https://code.google.com/p/nativeclient/issues/detail?id=3127

6 years, 10 months ago (2014-02-12 21:04:32 UTC) #4

David Yen

6 years, 10 months ago (2014-02-12 21:21:46 UTC) #5

Message was sent while issue was closed.

On 2014/02/12 21:04:32, Mark Seaborn wrote:
> For the record, this should have:
> BUG=https://code.google.com/p/nativeclient/issues/detail?id=3127

Whoops... I have no idea how I pasted the wrong link.

Expand Messages | Collapse Messages