Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1606123003: Split summary_test into multiple files. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split summary_test into multiple files. The file has over 1000 tests, takes 8 seconds to run, and breaks naturally into 3 nearly equal-sized pieces. It seems reasonable to split it up. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9ad3ef570b97d0f7c6ebaf1d9fc45662fb24173d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -4744 lines) Patch
A pkg/analyzer/test/src/summary/prelinker_test.dart View 1 chunk +89 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +114 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/summary/summarize_elements_test.dart View 1 chunk +147 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/src/summary/summary_common.dart View 4 chunks +1 line, -292 lines 0 comments Download
D pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +0 lines, -4450 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-20 18:35:23 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-20 18:37:58 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-20 18:42:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ad3ef570b97d0f7c6ebaf1d9fc45662fb24173d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698