Issue 1606083002: Roll angle to 46ccef1992a8ede16a596c3dd73cff13c047267d and enable gn check globally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1606083002: Roll angle to 46ccef1992a8ede16a596c3dd73cff13c047267d and enable gn check globally. (Closed)

Created:
4 years, 11 months ago by viettrungluu

Modified:
4 years, 11 months ago

Reviewers:
kulakowski

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Roll angle to 46ccef1992a8ede16a596c3dd73cff13c047267d and enable gn check globally. (From bdd419f9f5b006e913606e7363125942c8ae06bc. This rolls angle forward by about two months. "mojob.py test" passes and the spinning cube still works, at least on Linux.) R=kulakowski@chromium.org BUG=fixes #629 Committed: https://chromium.googlesource.com/external/mojo/+/848a5974567b775734d3bc478e5fa1bcd9a7fc49

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -32 lines)			Patch
	M	.gn	View		1 chunk	+0 lines, -31 lines	0 comments	Download
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

viettrungluu

4 years, 11 months ago (2016-01-20 00:59:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
848a5974567b775734d3bc478e5fa1bcd9a7fc49 (presubmit successful).