Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 160605: Support "break"/suspend command (Closed)

Created:
11 years, 4 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Maybe we should expose "break" command via DebuggerAgent. This command ("break") is intentionally non-JSON, as it corresponds to the fact that JavaScript VM is being busy right now so we can't parse JSON. This command has higher QoS that other commands, because it evades normal command queue.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/debug.cc View 1 1 chunk +23 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Peter Rybin
11 years, 4 months ago (2009-08-04 21:51:20 UTC) #1
Mikhail Naganov
http://codereview.chromium.org/160605/diff/1001/5 File src/debug.cc (right): http://codereview.chromium.org/160605/diff/1001/5#newcode2290 Line 2290: if (CompareAsciiWithUtf16("break", command)) { FYI, an alternative to ...
11 years, 4 months ago (2009-08-05 07:37:00 UTC) #2
Søren Thygesen Gjesse
On 2009/08/04 21:51:20, Peter Rybin wrote: > Adding a break command the the debugger agent ...
11 years, 4 months ago (2009-08-05 07:45:21 UTC) #3
Peter Rybin
11 years, 3 months ago (2009-08-30 19:21:01 UTC) #4
Hi Soren

Thank you for explanation. Let me withdraw my CL now.

On the other hand I'm interested in developing support of V8 debugger because of
chromedevtools project I'm working on.

As I understand our main issue is multi-thread aspects V8<->some_debug_agent
communication.

Couple of Qs:

1. Can we have all debug commands "forced", which means that if V8 is running at
the moment, it interrupts and process command.

2. Provided #1 == true, "break" seems to be a regular JSON command. Do we need
an out-of-order hi-pri "break" command in this case?  We probably only need it
to interrupt other requests, notably "evaluate". I don't know it we really want
to support this, but it looks nice.

3. Can we start adding API for embedder to run for us a spare cycle of V8 to
process pending debug command? I'll try to submit a corresponding CL soon.

Peter

Powered by Google App Engine
This is Rietveld 408576698