Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1606043003: remove unused method in ElementResolver (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, Paul Berry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove unused method in ElementResolver I forgot to delete this in a previous CL R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8aa3df862b680bcfe23bc11ad90c45c796b71099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jennifer Messerly
Figured it'd be nice to make the hint go away. :)
4 years, 11 months ago (2016-01-19 22:04:59 UTC) #2
Paul Berry
Let's get Brian's opinion since this method was added by his CL earlier today (https://github.com/dart-lang/sdk/commit/6f56368747983295ad378a063dca278488a4d5f6)
4 years, 11 months ago (2016-01-19 22:11:38 UTC) #4
Brian Wilkerson
I didn't intentionally add that method. I remember seeing that method move from one place ...
4 years, 11 months ago (2016-01-19 22:17:17 UTC) #5
Jennifer Messerly
On 2016/01/19 22:17:17, Brian Wilkerson wrote: > I didn't intentionally add that method. I remember ...
4 years, 11 months ago (2016-01-19 22:30:45 UTC) #6
Jennifer Messerly
4 years, 11 months ago (2016-01-19 23:54:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8aa3df862b680bcfe23bc11ad90c45c796b71099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698