Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2684)

Unified Diff: chrome/browser/gtk/bookmark_editor_gtk.cc

Issue 160603: GTK: Make folder tree views expand columns properly, also refactor the code i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/bookmark_manager_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_editor_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_editor_gtk.cc (revision 22391)
+++ chrome/browser/gtk/bookmark_editor_gtk.cc (working copy)
@@ -157,24 +157,8 @@
tree_store_ = bookmark_utils::MakeFolderTreeStore();
bookmark_utils::AddToTreeStore(bb_model_, selected_id,
tree_store_, &selected_iter);
-
- GtkTreeViewColumn* icon_column =
- gtk_tree_view_column_new_with_attributes(
- "FolderIcon", gtk_cell_renderer_pixbuf_new(), "pixbuf",
- bookmark_utils::FOLDER_ICON, NULL);
- GtkTreeViewColumn* name_column =
- gtk_tree_view_column_new_with_attributes(
- "FolderName", gtk_cell_renderer_text_new(), "text",
- bookmark_utils::FOLDER_NAME, NULL);
-
- tree_view_ = gtk_tree_view_new_with_model(GTK_TREE_MODEL(tree_store_));
- // Let |tree_view| own the store.
- g_object_unref(tree_store_);
- gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(tree_view_), FALSE);
- gtk_tree_view_append_column(GTK_TREE_VIEW(tree_view_), icon_column);
- gtk_tree_view_append_column(GTK_TREE_VIEW(tree_view_), name_column);
+ tree_view_ = bookmark_utils::MakeTreeViewForStore(tree_store_);
gtk_widget_set_size_request(tree_view_, kTreeWidth, kTreeHeight);
-
tree_selection_ = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree_view_));
GtkTreePath* path = NULL;
« no previous file with comments | « no previous file | chrome/browser/gtk/bookmark_manager_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698