Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: chrome/browser/gtk/bookmark_manager_gtk.cc

Issue 160603: GTK: Make folder tree views expand columns properly, also refactor the code i... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/gtk/bookmark_editor_gtk.cc ('k') | chrome/browser/gtk/bookmark_tree_model.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/bookmark_manager_gtk.h" 5 #include "chrome/browser/gtk/bookmark_manager_gtk.h"
6 6
7 #include <gdk/gdkkeysyms.h> 7 #include <gdk/gdkkeysyms.h>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 GtkWidget* vbox = gtk_vbox_new(FALSE, 0); 426 GtkWidget* vbox = gtk_vbox_new(FALSE, 0);
427 gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0); 427 gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
428 gtk_box_pack_start(GTK_BOX(vbox), paned_, TRUE, TRUE, 0); 428 gtk_box_pack_start(GTK_BOX(vbox), paned_, TRUE, TRUE, 0);
429 gtk_container_add(GTK_CONTAINER(window_), vbox); 429 gtk_container_add(GTK_CONTAINER(window_), vbox);
430 430
431 ResetOrganizeMenu(true); 431 ResetOrganizeMenu(true);
432 } 432 }
433 433
434 GtkWidget* BookmarkManagerGtk::MakeLeftPane() { 434 GtkWidget* BookmarkManagerGtk::MakeLeftPane() {
435 left_store_ = bookmark_utils::MakeFolderTreeStore(); 435 left_store_ = bookmark_utils::MakeFolderTreeStore();
436 left_tree_view_ = bookmark_utils::MakeTreeViewForStore(left_store_);
436 437
437 GtkTreeViewColumn* icon_column = gtk_tree_view_column_new_with_attributes(
438 "", gtk_cell_renderer_pixbuf_new(), "pixbuf", bookmark_utils::FOLDER_ICON,
439 NULL);
440 GtkTreeViewColumn* name_column = gtk_tree_view_column_new_with_attributes(
441 "", gtk_cell_renderer_text_new(), "text", bookmark_utils::FOLDER_NAME,
442 NULL);
443
444 left_tree_view_ = gtk_tree_view_new_with_model(GTK_TREE_MODEL(left_store_));
445 // Let |tree_view| own the store.
446 g_object_unref(left_store_);
447 gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(left_tree_view_), FALSE);
448 gtk_tree_view_append_column(GTK_TREE_VIEW(left_tree_view_), icon_column);
449 gtk_tree_view_append_column(GTK_TREE_VIEW(left_tree_view_), name_column);
450 // When a row is collapsed that contained the selected node, we want to select 438 // When a row is collapsed that contained the selected node, we want to select
451 // it. 439 // it.
452 g_signal_connect(left_tree_view_, "row-collapsed", 440 g_signal_connect(left_tree_view_, "row-collapsed",
453 G_CALLBACK(OnLeftTreeViewRowCollapsed), this); 441 G_CALLBACK(OnLeftTreeViewRowCollapsed), this);
454 g_signal_connect(left_tree_view_, "focus-in-event", 442 g_signal_connect(left_tree_view_, "focus-in-event",
455 G_CALLBACK(OnLeftTreeViewFocusIn), this); 443 G_CALLBACK(OnLeftTreeViewFocusIn), this);
456 g_signal_connect(left_tree_view_, "button-press-event", 444 g_signal_connect(left_tree_view_, "button-press-event",
457 G_CALLBACK(OnTreeViewButtonPress), this); 445 G_CALLBACK(OnTreeViewButtonPress), this);
458 g_signal_connect(left_tree_view_, "button-release-event", 446 g_signal_connect(left_tree_view_, "button-release-event",
459 G_CALLBACK(OnTreeViewButtonRelease), this); 447 G_CALLBACK(OnTreeViewButtonRelease), this);
(...skipping 945 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 } else if (id == IDS_BOOKMARK_MANAGER_EXPORT_MENU) { 1393 } else if (id == IDS_BOOKMARK_MANAGER_EXPORT_MENU) {
1406 if (g_browser_process->io_thread()) { 1394 if (g_browser_process->io_thread()) {
1407 bookmark_html_writer::WriteBookmarks( 1395 bookmark_html_writer::WriteBookmarks(
1408 g_browser_process->io_thread()->message_loop(), model_, 1396 g_browser_process->io_thread()->message_loop(), model_,
1409 path.ToWStringHack()); 1397 path.ToWStringHack());
1410 } 1398 }
1411 } else { 1399 } else {
1412 NOTREACHED(); 1400 NOTREACHED();
1413 } 1401 }
1414 } 1402 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/bookmark_editor_gtk.cc ('k') | chrome/browser/gtk/bookmark_tree_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698