Compile FileCache related files only on Chrome OS.

Compile FileCache related files only on Chrome OS.

BUG=533750
TEST=build passes

Committed: https://crrev.com/8bff65f0ae467f7bf332832cd506a2b8c2069f12
Cr-Commit-Position: refs/heads/master@{#371342}

[yawano, 2016-01-22 04:55:29]

yawano@chromium.org changed reviewers:
+ hashimoto@chromium.org, thestig@chromium.org

[yawano, 2016-01-22 04:55:30]

PTAL. While I've written similar CL at https://crrev.com/1528323004, it broke
build bot and reverted. This time, I wrote smaller CL, and want to try it again.
I'll move Chrome OS related files later.

@hashimoto: files under components/
@thestig: files under chrome/

Thank you!

[hashimoto, 2016-01-22 05:39:22]

https://codereview.chromium.org/1606013005/diff/40001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/1606013005/diff/40001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:459: deps += [ "//components/drive:drive_chromeos" ]
Isn't it better to put this in chrome/browser/chromeos/BUILD.gn?

https://codereview.chromium.org/1606013005/diff/40001/components/drive.gypi
File components/drive.gypi (right):

https://codereview.chromium.org/1606013005/diff/40001/components/drive.gypi#n...
components/drive.gypi:87: # TODO(yawano): move these files under
components/drive/chromeos.
Please add the same TODO to drive_test_support_chromeos and GN files.

[yawano, 2016-01-22 06:18:59]

yawano@chromium.org changed reviewers:
+ satorux@chromium.org

[yawano, 2016-01-22 06:18:59]

Thank you! Add satorux@ as a reviewer.

satorux@: PTAL c/b/chromeos/BUILD.gn. Thank you!

https://codereview.chromium.org/1606013005/diff/40001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/1606013005/diff/40001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:459: deps += [ "//components/drive:drive_chromeos" ]
On 2016/01/22 05:39:22, hashimoto wrote:
> Isn't it better to put this in chrome/browser/chromeos/BUILD.gn?

Done.

https://codereview.chromium.org/1606013005/diff/40001/components/drive.gypi
File components/drive.gypi (right):

https://codereview.chromium.org/1606013005/diff/40001/components/drive.gypi#n...
components/drive.gypi:87: # TODO(yawano): move these files under
components/drive/chromeos.
On 2016/01/22 05:39:22, hashimoto wrote:
> Please add the same TODO to drive_test_support_chromeos and GN files.

Done.

[hashimoto, 2016-01-22 06:29:47]

lgtm

https://codereview.chromium.org/1606013005/diff/60001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/1606013005/diff/60001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:1288: deps += [
"//components/drive:test_support_chromeos" ]
Can't this be also moved to chrome/browser/chromeos/BUILD.gn?

[yawano, 2016-01-22 06:43:56]

Thank you for the review!

https://codereview.chromium.org/1606013005/diff/60001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/1606013005/diff/60001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:1288: deps += [
"//components/drive:test_support_chromeos" ]
On 2016/01/22 06:29:47, hashimoto wrote:
> Can't this be also moved to chrome/browser/chromeos/BUILD.gn?

Done.

[Lei Zhang, 2016-01-25 21:41:29]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-01-25 21:41:29]

lgtm

[Lei Zhang, 2016-01-25 21:41:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1606013005/#ps80001
(title: "Move test_support_chromeos to c/b/chromeos.")

[commit-bot: I haz the power, 2016-01-25 21:43:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606013005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606013005/80001

[commit-bot: I haz the power, 2016-01-25 23:11:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-25 23:12:42]

Description was changed from

==========
Compile FileCache related files only on Chrome OS.

BUG=533750
TEST=build passes
==========

to

==========
Compile FileCache related files only on Chrome OS.

BUG=533750
TEST=build passes

Committed: https://crrev.com/8bff65f0ae467f7bf332832cd506a2b8c2069f12
Cr-Commit-Position: refs/heads/master@{#371342}
==========

[commit-bot: I haz the power, 2016-01-25 23:12:43]

Patchset 5 (id:??) landed as
https://crrev.com/8bff65f0ae467f7bf332832cd506a2b8c2069f12
Cr-Commit-Position: refs/heads/master@{#371342}