BLE GATT service implementation in Chrome for Windows 8 and later

BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It implements BluetoothGattService, BluetoothGattCharacteristic, BluetoothGattDescriptor and so on. Right now, we can not programmatically pair Bluetooth device, but after manually bond the BLE device, Windows can auto reconnect to it when necessary (write/register notification).

BUG=579202

[gogerald1, 2016-01-19 18:55:20]

Description was changed from

==========
remove patch file


format


rebase

BUG=
==========

to

==========
BLE Apis on Windows

BUG=
==========

[gogerald1, 2016-01-19 18:58:00]

Description was changed from

==========
BLE Apis on Windows

BUG=
==========

to

==========
Bluetooth low energy functions on Windows 8 and later

BUG=
==========

[gogerald1, 2016-01-19 19:00:08]

Description was changed from

==========
Bluetooth low energy functions on Windows 8 and later

BUG=
==========

to

==========
Bluetooth low energy functions for Windows 8 and later

BUG=
==========

[gogerald1, 2016-01-19 19:28:44]

Description was changed from

==========
Bluetooth low energy functions for Windows 8 and later

BUG=
==========

to

==========
Implement Bluetooth low energy functions for Windows 8 and later

BUG=
==========

[gogerald1, 2016-01-19 19:29:29]

Description was changed from

==========
Implement Bluetooth low energy functions for Windows 8 and later

BUG=
==========

to

==========
Bluetooth low energy functions implementation for Windows 8 and late

BUG=
==========

[gogerald1, 2016-01-19 19:30:00]

Description was changed from

==========
Bluetooth low energy functions implementation for Windows 8 and late

BUG=
==========

to

==========
Bluetooth low energy implementation for Windows 8 and later

BUG=
==========

[gogerald1, 2016-01-19 19:35:58]

Description was changed from

==========
Bluetooth low energy implementation for Windows 8 and later

BUG=
==========

to

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. 

BUG=
==========

[gogerald1, 2016-01-19 20:12:44]

Description was changed from

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. 

BUG=
==========

to

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we could not programmatically Bluetooth
device, but after manually bonded remote BLE, it will auto re-connect when
necessary (write/register events).

BUG=
==========

[gogerald1, 2016-01-19 20:13:44]

Description was changed from

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we could not programmatically Bluetooth
device, but after manually bonded remote BLE, it will auto re-connect when
necessary (write/register events).

BUG=
==========

to

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we could not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register events).

BUG=
==========

[gogerald1, 2016-01-19 20:14:46]

Description was changed from

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we could not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register events).

BUG=
==========

to

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we could not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 20:36:18]

Description was changed from

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we could not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

to

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:10:19]

Description was changed from

==========
Bluetooth low energy implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:11:12]

Description was changed from

==========
BLE GATT service implementation for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:16:38]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto re-connect when
necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto reconnect when
necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:32:06]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy interfaces in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto reconnect when
necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto reconnect when
necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:34:10]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic and
BluetoothGattDescriptor. Right now, we can not programmatically pair Bluetooth
device, but after manually bond the BLE device, it will auto reconnect when
necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, the device could be
auto reconnected when necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:39:38]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, the device could be
auto reconnected when necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification).

BUG=
==========

[gogerald1, 2016-01-19 21:39:56]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification).

BUG=
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification).

BUG= 579202
==========

[gogerald1, 2016-01-20 15:28:27]

gogerald@chromium.org changed reviewers:
+ gogerald@chromium.org, rpaquay@chromium.org

[gogerald1, 2016-01-20 15:28:28]

Hi Renaud, please help review this CL for implementing BLE GATT service in
Chrome for Windows.

Thanks,

[rpaquay, 2016-01-21 18:05:44]

rpaquay@chromium.org changed reviewers:
+ ortuno@chromium.org

[rpaquay, 2016-01-21 18:06:20]

On 2016/01/20 15:28:28, gogerald1 wrote:
> Hi Renaud, please help review this CL for implementing BLE GATT service in
> Chrome for Windows.
> 
> Thanks,

Added ortuno@ as reviewer, as this CL is not trivial.

[scheib, 2016-01-21 18:18:50]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 18:19:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606013002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606013002/100001

[ortuno, 2016-01-21 19:00:42]

https://codereview.chromium.org/1606013002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_win.cc (right):

https://codereview.chromium.org/1606013002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_win.cc:183: void
BluetoothDeviceWin::CreateGattConnection(
I noticed you didn't implement CreateGattConnection or DisconnectGatt. Is that
because there are no APIs to control connection in windows?

[commit-bot: I haz the power, 2016-01-21 19:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 19:27:17]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-01-21 20:00:20]

https://codereview.chromium.org/1606013002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_win.cc (right):

https://codereview.chromium.org/1606013002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_win.cc:183: void
BluetoothDeviceWin::CreateGattConnection(
On 2016/01/21 19:00:42, ortuno wrote:
> I noticed you didn't implement CreateGattConnection or DisconnectGatt. Is that
> because there are no APIs to control connection in windows?

Yes, I searched it for a while, haven't found any clew to do that, but bonded
(manually) BLE device could auto re-connect to each other when trying to write
data or register event. We could add it later when it is available.

[gogerald1, 2016-01-21 22:30:59]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification).

BUG= 579202
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification). Refer this
document for detail
https://docs.google.com/a/google.com/document/d/13AO-HCw4mIIGvcbXXY4B5KyG-08V...

BUG= 579202
==========

[gogerald1, 2016-01-21 22:33:55]

Description was changed from

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification). Refer this
document for detail
https://docs.google.com/a/google.com/document/d/13AO-HCw4mIIGvcbXXY4B5KyG-08V...

BUG= 579202
==========

to

==========
BLE GATT service implementation in Chrome for Windows 8 and later

This CL implements Bluetooth low energy GATT service in Chrome for Windows. It
implements BluetoothGattService, BluetoothGattCharacteristic,
BluetoothGattDescriptor and so on. Right now, we can not programmatically pair
Bluetooth device, but after manually bond the BLE device, Windows can auto
reconnect to it when necessary (write/register notification).

BUG= 579202
==========

[scheib, 2016-01-24 01:37:59]

As discussed over email/chat. 

Please split up the patch, for example into 
...
- basic service support
- BluetoothGattService::GetCharacteristics & stub BluetoothGattCharacteristic
(getUUID, properties etc)
- BluetoothGattCharacteristic read/writes
- BluetoothGattCharacteristic notify sessions
...
See examples in 
https://chromium.googlesource.com/chromium/src/+log/master/device/bluetooth/a...

The smaller patches will make review considerably faster and more effective at
finding issues.

Please use the cross platform testing fixture:
https://docs.google.com/document/d/1mBipxn1sJu6jMqP0RQZpkYXC1o601bzLCpCxwTA2y...