Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: site/dev/contrib/submit.md

Issue 1606003003: Fix patch check-in instructions for non-committers (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: formatting fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site/dev/contrib/submit.md
diff --git a/site/dev/contrib/submit.md b/site/dev/contrib/submit.md
index 1260f0582bb886d6732702b93189e0640ae4bd8b..12adf519581bceba1da0d76a3eb705f4a524027a 100644
--- a/site/dev/contrib/submit.md
+++ b/site/dev/contrib/submit.md
@@ -199,27 +199,27 @@ commit your change directly to Skia's repository.
If you don't have committer rights in https://skia.googlesource.com/skia.git ...
first of all, thanks for submitting your patch! We really appreciate these
-submissions. Unfortunately, we don't yet have a way for Skia committers to mark
-a patch as "approved" and thus allow non-committers to commit them. So instead,
-please ask a Skia committer to land your patch for you or land using the commit
-queue.
-
-As part of this process, the Skia committer may create a new codereview
-containing your patch (perhaps with some small adjustments at her discretion).
-If so, you can mark your codereview as "Closed", and update it with a link to
-the new codereview.
-
-### Skia committers:
- * tips on how to apply the externally provided patch are [here](./patch)
+submissions. After receiving an LGTM from a committer, you will be able to
+check the commit box and submit your patch via the commit queue.
+
+In special instances, a Skia committer may assist you in landing the change by
+creating a new codereview containing your patch (perhaps with some small
+adjustments at his/her discretion). If so, you can mark your codereview as
+"Closed", and update it with a link to the new codereview.
+
+### Skia committers
+ * tips on how to apply an externally provided patch are [here](./patch)
* when landing externally contributed patches, please note the original
contributor's identity (and provide a link to the original codereview) in the commit message
-git-cl will squash all your commits into a single one with the description you used when you uploaded your change.
-
-~~~~
-git cl land
-~~~~
-or
-~~~~
-git cl land -c 'Contributor Name <email@example.com>'
-~~~~
+ git-cl will squash all your commits into a single one with the description you used when you uploaded your change.
+
+ ~~~~
+ git cl land
+ ~~~~
+
+ or
+
+ ~~~~
+ git cl land -c 'Contributor Name <email@example.com>'
+ ~~~~
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698