Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 16060004: When cross-compiling, also build and link run_vm_tests for the host architecture. (Closed)

Created:
7 years, 6 months ago by zra
Modified:
7 years, 6 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, ricow1, kustermann
Visibility:
Public.

Description

When cross-compiling, also build and link run_vm_tests for the host architecture. E.g. for ARM, run_vm_tests for the host architecture will end up in out/DebugARM/run_vm_tests.host. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M runtime/bin/bin.gypi View 3 chunks +54 lines, -0 lines 0 comments Download
M runtime/bin/net/nss.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M runtime/bin/net/sqlite.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/net/ssl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/net/zlib.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 6 months ago (2013-05-28 16:46:55 UTC) #1
Ivan Posva
LGTM -ip
7 years, 6 months ago (2013-05-28 17:48:15 UTC) #2
zra
7 years, 6 months ago (2013-05-28 17:56:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698