Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1605993003: Disable pnacl toolchain build under emscripten (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 11 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Disable pnacl toolchain build under emscripten One day this would be awesome, but we aren't there yet. BUG= https://bugs.chromium.org/p/naclports/issues/detail?id=244 Committed: https://chromium.googlesource.com/webports/+/5af37c407b8b19d268a51d4e83deedbe53a2057e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ports/pnacl/pkg_info View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Sam Clegg
4 years, 11 months ago (2016-01-19 18:31:25 UTC) #3
bradnelson
lgtm
4 years, 11 months ago (2016-01-19 19:03:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605993003/1
4 years, 11 months ago (2016-01-19 19:04:00 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 19:07:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/webports/+/5af37c407b8b19d268a51d4e83deedbe...

Powered by Google App Engine
This is Rietveld 408576698