Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1605973002: Remove rule prohibiting including src/v8.h (Closed)

Created:
4 years, 11 months ago by Michael Lippautz
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove rule prohibiting including src/v8.h The dust has settled and it can now be used like any other header file R=mstarzinger@chromium.org Committed: https://crrev.com/1e0fd2a5b918648e5a13021b4d622d1269ddb8ed Cr-Commit-Position: refs/heads/master@{#33395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Lippautz
4 years, 11 months ago (2016-01-19 15:34:51 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 11 months ago (2016-01-19 18:29:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605973002/1
4 years, 11 months ago (2016-01-19 19:49:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 20:06:26 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 20:06:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e0fd2a5b918648e5a13021b4d622d1269ddb8ed
Cr-Commit-Position: refs/heads/master@{#33395}

Powered by Google App Engine
This is Rietveld 408576698