Issue 160596: This fixes the npapi-response-headers layout test, which started failing afte...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160596: This fixes the npapi-response-headers layout test, which started failing afte... (Closed)

Created:
11 years, 4 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review), amit, Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This fixes the npapi-response-headers layout test, which started failing after my CL 22369. When a plugin stream load finishes it deletes the corresponding client information maintained by WebPluginImpl. We were referencing this structure after a call to DidFinishLoading on the resource client which caused this issue. This fixes bug http://code.google.com/p/chromium/issues/detail?id=18392 Bug=18392 Test=Covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22431

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	webkit/glue/webplugin_impl.cc	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/160596/diff/1/2 File webkit/glue/webplugin_impl.cc (right): http://codereview.chromium.org/160596/diff/1/2#newcode1087 Line 1087: // The ClientInfo can get deleted in the ...

11 years, 4 months ago (2009-08-04 19:43:54 UTC) #2

ananta

11 years, 4 months ago (2009-08-04 21:22:47 UTC) #3

lgtm

Expand Messages | Collapse Messages