Remove tracking of 'closed subpath' state from SVGPathBuilder

Remove tracking of 'closed subpath' state from SVGPathBuilder

For any implicit moveto (like: "M0,0z L..." it would not do the right
thing (clear m_closed), which could result in unwanted calls to
Path::closeSubpath if a(n explicit) moveto followed. This in turn would
result in rendering errors (the "close" line being stroked that should
not.)
SkPath seems to do a much better job of this already - and Path is just
a thin wrapper around SkPath in these cases - so just drop the
SVGPathBuilder::m_closed flag and leave the work to SkPath.

BUG=578254
Committed: https://crrev.com/7c511917b445472dd0bb5a75600830bce7dadb4f
Cr-Commit-Position: refs/heads/master@{#370168}

[fs, 2016-01-19 14:34:14]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[fs, 2016-01-19 14:34:15]

Remove code (and data) - fix bug. Win? =P

[f(malita), 2016-01-19 14:51:59]

On 2016/01/19 14:34:15, fs wrote:
> Remove code (and data) - fix bug. Win? =P

LGTM!

[pdr., 2016-01-19 19:39:40]

On 2016/01/19 at 14:51:59, fmalita wrote:
> On 2016/01/19 14:34:15, fs wrote:
> > Remove code (and data) - fix bug. Win? =P
> 
> LGTM!

#winning

#hashtagLGTM

[pdr., 2016-01-19 19:39:49]

LGTM

[pdr., 2016-01-19 19:39:55]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-01-19 19:40:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605943002/1

[commit-bot: I haz the power, 2016-01-19 19:45:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-19 19:47:31]

Description was changed from

==========
Remove tracking of 'closed subpath' state from SVGPathBuilder

For any implicit moveto (like: "M0,0z L..." it would not do the right
thing (clear m_closed), which could result in unwanted calls to
Path::closeSubpath if a(n explicit) moveto followed. This in turn would
result in rendering errors (the "close" line being stroked that should
not.)
SkPath seems to do a much better job of this already - and Path is just
a thin wrapper around SkPath in these cases - so just drop the
SVGPathBuilder::m_closed flag and leave the work to SkPath.

BUG=578254
==========

to

==========
Remove tracking of 'closed subpath' state from SVGPathBuilder

For any implicit moveto (like: "M0,0z L..." it would not do the right
thing (clear m_closed), which could result in unwanted calls to
Path::closeSubpath if a(n explicit) moveto followed. This in turn would
result in rendering errors (the "close" line being stroked that should
not.)
SkPath seems to do a much better job of this already - and Path is just
a thin wrapper around SkPath in these cases - so just drop the
SVGPathBuilder::m_closed flag and leave the work to SkPath.

BUG=578254

Committed: https://crrev.com/7c511917b445472dd0bb5a75600830bce7dadb4f
Cr-Commit-Position: refs/heads/master@{#370168}
==========

[commit-bot: I haz the power, 2016-01-19 19:47:32]

Patchset 1 (id:??) landed as
https://crrev.com/7c511917b445472dd0bb5a75600830bce7dadb4f
Cr-Commit-Position: refs/heads/master@{#370168}