Docserver: Fixes for expand/collapse issue and fatnav closing on mouseleave.

Docserver: Fixes for expand/collapse issue and fatnav closing on mouseleave.

Formerly known as CL 138213007. See notes over there: https://codereview.chromium.org/138213007/

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250914

[Arthur Evans, 2014-02-12 19:15:43]

Ben,

Jeffrey reviewed this originally (see the linked CL). Meggin said that Jeffrey
isn't around this week, and the fatnav behavior change is a launch requirement.

Could you review this?

Original CL is at: https://codereview.chromium.org/138213007/

Thanks,
Arthur

[not at google - send to devlin, 2014-02-12 20:37:25]

I didn't look at this, Renato knows the code much better, rubberstamp lgtm once
he's happy with it.

[Arthur Evans, 2014-02-13 01:34:13]

On 2014/02/12 20:37:25, kalman wrote:
> I didn't look at this, Renato knows the code much better, rubberstamp lgtm
once
> he's happy with it.

Renato reviewed & tested & OK'd this. He did find a similar issue with the menu
button. 
I'll open up a separate CL for that.

[Renato Mangini (chromium), 2014-02-13 01:35:14]

aside from the nits below, lgtm.

https://codereview.chromium.org/160593003/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/static/js/article.js (right):

https://codereview.chromium.org/160593003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/js/article.js:42:
sidebar.classList.remove('sticky');
nit: fix indentation

https://codereview.chromium.org/160593003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/js/article.js:47: // Prevent permalinks
from appearing on mobile.
I think this comment is wrong, since removing a "no-permalink" class should mean
the opposite.

https://codereview.chromium.org/160593003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/static/js/article.js:49: 
nit: remove white lines in these if/else blocks, since they are not used to
separate semantic blocks.

[Arthur Evans, 2014-02-13 02:05:16]

The CQ bit was checked by arthure@chromium.org

[Arthur Evans, 2014-02-13 02:06:16]

The CQ bit was unchecked by arthure@chromium.org

[Arthur Evans, 2014-02-13 02:07:26]

The CQ bit was checked by arthure@chromium.org

[commit-bot: I haz the power, 2014-02-13 02:18:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arthure@chromium.org/160593003/110001

[commit-bot: I haz the power, 2014-02-13 02:33:53]

Change committed as 250914