Issue 1605923005: Improve failure mode when there is no SDK (issue 25528)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1605923005: Improve failure mode when there is no SDK (issue 25528) (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson

Modified:
4 years, 11 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

I believe that the current behavior allows a `null` to be inserted into the list ...

4 years, 11 months ago (2016-01-19 18:13:10 UTC) #2

Brian Wilkerson

4 years, 11 months ago (2016-01-19 18:16:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2f5b876c7e7008501c79e42fc877707c6df6831 (presubmit successful).