[content shell] only allow test plugins to load during layout tests

[content shell] only allow test plugins to load during layout tests

BUG=242291
TBR=marja@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202392

[marja, 2013-05-27 08:25:49]

lgtm

[jochen (gone - plz use gerrit), 2013-05-27 08:28:40]

tbr joi@ for the content/public cleanup

[jochen (gone - plz use gerrit), 2013-05-27 09:24:13]

Committed patchset #1 manually as r202392 (presubmit successful).

[Jói, 2013-05-27 10:53:49]

LGTM for //content/public.

[Noel Gordon, 2013-05-28 04:29:12]

Can't deduce from the change description "why" this change was needed.

Seems plugins/embed-attributes-style.html started failing after this change,
maybe because it tries to <embed> a video/quicktime plugin?

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plu...

[jochen (gone - plz use gerrit), 2013-05-28 07:15:48]

On 2013/05/28 04:29:12, Noel Gordon (Google) wrote:
> Can't deduce from the change description "why" this change was needed.

as described in the referenced bugs, some plugins spill debug output to stdout
and ruin test results.

> 
> Seems plugins/embed-attributes-style.html started failing after this change,
> maybe because it tries to <embed> a video/quicktime plugin?
> 

I had a look at the test, and it now matches the output on the other
platforms... I'd argue that this is actually an improvement

>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plu...

[abarth-chromium, 2013-05-28 07:56:12]

https://codereview.chromium.org/16059004/diff/1/content/shell/shell_plugin_se...
File content/shell/shell_plugin_service_filter.cc (right):

https://codereview.chromium.org/16059004/diff/1/content/shell/shell_plugin_se...
content/shell/shell_plugin_service_filter.cc:27: return false;
Why not just:

return plugin->name == ASCIIToUTF16("WebKit Test PlugIn") ||
    plugin->name == ASCIIToUTF16("NPAPI Test Plugin";

?