Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 160590: A patch for http://crbug.com/17400... (Closed)

Created:
11 years, 4 months ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Base URL:
http://svn.webkit.org/repository/webkit/trunk/WebCore/
Visibility:
Public.

Description

Hi Dimitri, Please take the patch, it should be committed to WebKit tree. Feel free to make changes, and I am happy to help. Thanks A patch for http://crbug.com/17400 Event listeners on element can create cycler references between ref counted C++ objects and JS wrappers. The issue is the same as XHR, and we handled there by using hidden references on JS side to track references. This patch does the same thing for event listeners on Node and Document. Event listeners on Window object may have similar cycler reference, and it can be handled using the same solution.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -70 lines) Patch
M bindings/scripts/CodeGeneratorV8.pm View 4 chunks +19 lines, -7 lines 0 comments Download
M bindings/v8/V8AbstractEventListener.h View 1 chunk +1 line, -0 lines 0 comments Download
M bindings/v8/V8DOMWrapper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bindings/v8/V8LazyEventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M bindings/v8/V8Utilities.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M bindings/v8/custom/V8CustomBinding.h View 2 chunks +6 lines, -3 lines 0 comments Download
M bindings/v8/custom/V8ElementCustom.cpp View 3 chunks +0 lines, -40 lines 0 comments Download
M bindings/v8/custom/V8NodeCustom.cpp View 3 chunks +63 lines, -11 lines 0 comments Download
M bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698