Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: third_party/WebKit/Source/web/TextFinder.h

Issue 1605863002: Restart search in page when new text is found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/TextFinder.h
diff --git a/third_party/WebKit/Source/web/TextFinder.h b/third_party/WebKit/Source/web/TextFinder.h
index e639c9716c52990d0ec0050511e41d9dd9a33fbe..be4a4dced72c8501b9d88de0f1794f1e2c8bde1b 100644
--- a/third_party/WebKit/Source/web/TextFinder.h
+++ b/third_party/WebKit/Source/web/TextFinder.h
@@ -56,7 +56,7 @@ public:
bool find(
int identifier, const WebString& searchText, const WebFindOptions&,
- bool wrapWithinFrame, WebRect* selectionRect);
+ bool wrapWithinFrame, WebRect* selectionRect, bool* activeNow);
esprehn 2016/02/10 01:17:08 = nullptr and then don't change the tons of calls
dvadym 2016/02/10 16:06:21 Done.
void stopFindingAndClearSelection();
void scopeStringMatches(
int identifier, const WebString& searchText, const WebFindOptions&,
@@ -157,7 +157,7 @@ private:
void addMarker(Range*, bool activeMatch);
// Sets the markers within a range as active or inactive.
- void setMarkerActive(Range*, bool active);
+ bool setMarkerActive(Range*, bool active);
esprehn 2016/02/10 01:17:08 what does the return mean?
dvadym 2016/02/10 16:06:21 I've added a comment: Returns true if at least one
// Removes all markers.
void unmarkAllTextMatches();

Powered by Google App Engine
This is Rietveld 408576698