Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 1605863002: Restart search in page when new text is found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, clean-up Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index 9ae9234584f187ee39b1ae311a96a13d014484d4..dde5a7b15b6756cf18edb47bb087bd16886fc3b2 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -561,10 +561,11 @@ public:
//
// Returns true if the search string was found, false otherwise.
virtual bool find(int identifier,
- const WebString& searchText,
- const WebFindOptions& options,
- bool wrapWithinFrame,
- WebRect* selectionRect) = 0;
+ const WebString& searchText,
+ const WebFindOptions&,
+ bool wrapWithinFrame,
+ WebRect* selectionRect,
+ bool& newTextFound) = 0;
Finnur 2016/01/20 14:14:03 style: The style guide says |out| parameters shoul
dvadym 2016/01/29 09:44:17 Thanks, I've changed to pointer and renamed to act
// Notifies the frame that we are no longer interested in searching.
// This will abort any asynchronous scoping effort already under way

Powered by Google App Engine
This is Rietveld 408576698