Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1605803002: [runtime] Migrate Object.getOwnPropertyNames to C++. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ObjectGetOwnPropertyDescriptor
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Migrate Object.getOwnPropertyNames to C++. The Object.getOwnPropertyNames method always calls into C++ anyway, so there's no point in having the JavaScript wrapper around at all. Drive-by-fix: Inline GetOwnEnumerablePropertyNames into its single call site. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/bf027fe756f62b4abcac8aa08134c8c5ed055620 Cr-Commit-Position: refs/heads/master@{#33380} Committed: https://crrev.com/6fc3149939deb59d06f2d70e85306ece5272ff0c Cr-Commit-Position: refs/heads/master@{#33417}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M src/js/v8natives.js View 1 2 4 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-19 06:54:23 UTC) #1
Benedikt Meurer
Hey Yang, Another one from v8natives. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-19 06:54:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605803002/1
4 years, 11 months ago (2016-01-19 06:55:42 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/9200)
4 years, 11 months ago (2016-01-19 06:56:13 UTC) #6
Yang
On 2016/01/19 06:56:13, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 11 months ago (2016-01-19 07:32:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605803002/20001
4 years, 11 months ago (2016-01-19 07:33:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 07:34:24 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bf027fe756f62b4abcac8aa08134c8c5ed055620 Cr-Commit-Position: refs/heads/master@{#33380}
4 years, 11 months ago (2016-01-19 07:35:11 UTC) #12
Michael Hablich
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1609173002/ by hablich@chromium.org. ...
4 years, 11 months ago (2016-01-20 08:19:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605803002/40001
4 years, 11 months ago (2016-01-20 18:15:31 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-20 19:30:16 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:30:57 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6fc3149939deb59d06f2d70e85306ece5272ff0c
Cr-Commit-Position: refs/heads/master@{#33417}

Powered by Google App Engine
This is Rietveld 408576698