Issue 16058005: PolicyDomainDescriptor must be RefCountedThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16058005: PolicyDomainDescriptor must be RefCountedThreadSafe. (Closed)

Created:
7 years, 6 months ago by Joao da Silva

Modified:
7 years, 6 months ago

Reviewers:
bartfab (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PolicyDomainDescriptor must be RefCountedThreadSafe. These objects are created on the UI thread but some of them are passed to the FILE thread, which may old the last reference. This was caught by the in_dtor_ check. Since they live across threads then they must be RefCountedThreadSafe. BUG=None R=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202452

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/policy/policy_domain_descriptor.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

7 years, 6 months ago (2013-05-27 18:05:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r202452 (presubmit successful).

Expand Messages | Collapse Messages