Issue 160575: Revert the revert of my DOM Storage LayoutTest enabling CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160575: Revert the revert of my DOM Storage LayoutTest enabling CL. (Closed)

Created:
11 years, 4 months ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
jam, abarth-chromium

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert the revert of my DOM Storage LayoutTest enabling CL. I had to revert because it broke Adam's isolated worlds layout tests. Revert of 22034 BUG=18412 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22453

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -4 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View	1	2 chunks	+46 lines, -4 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

11 years, 4 months ago (2009-08-04 20:05:32 UTC) #3

On 2009/08/04 19:06:56, Jeremy Orlow wrote:
> Ready for review.

LGTM.  I don't really know much about the individual tests, but we've got to
start somewhere.

Expand Messages | Collapse Messages