Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160573002: Move root_window_host* in aura to window_tree_host*. (Closed)

Created:
6 years, 10 months ago by Ben Goodger (Google)
Modified:
6 years, 10 months ago
Reviewers:
sky, Paweł Hajdan Jr.
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, viettrungluu+watch_chromium.org, tfarina, ben+aura_chromium.org, jam, abarth-chromium, Aaron Boodman, stuartmorgan+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Move root_window_host* in aura to window_tree_host*. R=sky@chromium.org TBR=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251379

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : y #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -8126 lines) Patch
ash/ash.gyp View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
ash/display/display_controller.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ash/display/mirror_window_controller.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ash/display/virtual_keyboard_window_controller.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ash/host/root_window_host_factory.h View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
ash/host/root_window_host_factory.cc View 1 2 3 4 5 6 1 chunk +0 lines, -31 lines 0 comments Download
ash/host/root_window_host_factory_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -40 lines 0 comments Download
ash/host/window_tree_host_factory.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ash/host/window_tree_host_factory.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ash/host/window_tree_host_factory_win.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
ash/shell.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ash/shell.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ash/shell/shell_delegate_impl.cc View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ash/test/ash_test_base.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
ash/test/ash_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
ash/test/test_metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
ash/test/test_shell_delegate.cc View 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/browser_process_platform_part_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/lifetime/application_lifetime_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/plugins/plugin_infobar_delegates.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/ash/chrome_shell_delegate.cc View 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/ash/launcher/chrome_launcher_controller_win.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/aura/active_desktop_monitor.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
chrome/browser/ui/aura/tabs/dock_info_auralinux.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/apps/native_app_window_views_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_root_window_host.h View 1 2 3 4 5 6 1 chunk +0 lines, -42 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.h View 1 2 3 4 5 6 1 chunk +0 lines, -79 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -334 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_root_window_host_x11.h View 1 2 3 4 5 6 1 chunk +0 lines, -52 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_root_window_host_x11.cc View 1 2 3 4 5 6 1 chunk +0 lines, -73 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_window_tree_host.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.h View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.h View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/frame/browser_frame_ashwin.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/frame/desktop_browser_frame_aura.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc View 1 2 3 4 5 6 4 chunks +7 lines, -7 lines 0 comments Download
chrome/browser/ui/views/frame/global_menu_bar_x11.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/ui/views/tabs/dock_info_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 3 chunks +12 lines, -12 lines 0 comments Download
mojo/examples/aura_demo/aura_demo.cc View 1 2 3 4 5 6 4 chunks +6 lines, -6 lines 0 comments Download
mojo/examples/aura_demo/demo_context_factory.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
mojo/examples/aura_demo/root_window_host_mojo.h View 1 2 3 4 5 6 1 chunk +0 lines, -81 lines 0 comments Download
mojo/examples/aura_demo/root_window_host_mojo.cc View 1 2 3 4 5 6 1 chunk +0 lines, -206 lines 0 comments Download
mojo/examples/aura_demo/window_tree_host_mojo.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
mojo/examples/aura_demo/window_tree_host_mojo.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
mojo/examples/launcher/launcher.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
mojo/mojo_examples.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
printing/printing_context_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
ui/aura/aura.gyp View 2 chunks +11 lines, -11 lines 0 comments Download
ui/aura/remote_root_window_host_win.h View 1 2 3 4 7 8 1 chunk +0 lines, -309 lines 0 comments Download
ui/aura/remote_root_window_host_win.cc View 1 2 3 4 1 chunk +0 lines, -780 lines 0 comments Download
ui/aura/remote_window_tree_host_win.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/remote_window_tree_host_win.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
ui/aura/root_window_host_mac.h View 1 chunk +0 lines, -63 lines 0 comments Download
ui/aura/root_window_host_mac.mm View 1 chunk +0 lines, -122 lines 0 comments Download
ui/aura/root_window_host_ozone.h View 1 chunk +0 lines, -64 lines 0 comments Download
ui/aura/root_window_host_ozone.cc View 1 2 3 4 1 chunk +0 lines, -130 lines 0 comments Download
ui/aura/root_window_host_win.h View 1 chunk +0 lines, -104 lines 0 comments Download
ui/aura/root_window_host_win.cc View 1 chunk +0 lines, -318 lines 0 comments Download
ui/aura/root_window_host_x11.h View 1 chunk +0 lines, -150 lines 0 comments Download
ui/aura/root_window_host_x11.cc View 1 chunk +0 lines, -1054 lines 0 comments Download
ui/aura/root_window_host_x11_unittest.cc View 1 chunk +0 lines, -272 lines 0 comments Download
ui/aura/test/aura_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/aura/window_tree_host.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/window_tree_host_delegate.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/window_tree_host_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/window_tree_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
ui/aura/window_tree_host_ozone.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/window_tree_host_ozone.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
ui/aura/window_tree_host_win.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/window_tree_host_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
ui/aura/window_tree_host_x11.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/aura/window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/aura/window_tree_host_x11_unittest.cc View 1 2 3 4 5 6 11 chunks +23 lines, -23 lines 0 comments Download
ui/events/event_utils.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/views.gyp View 1 2 3 4 5 6 3 chunks +8 lines, -8 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 3 4 5 6 24 chunks +59 lines, -59 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host.h View 1 2 3 4 5 6 1 chunk +0 lines, -162 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_observer_x11.h View 1 2 3 4 5 6 1 chunk +0 lines, -29 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_ozone.cc View 1 2 3 4 5 6 1 chunk +0 lines, -20 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 2 3 4 5 6 1 chunk +0 lines, -290 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1024 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_win_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -55 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 1 2 3 4 5 6 1 chunk +0 lines, -308 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1627 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_screen_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_observer_x11.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_ozone.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_win_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 2 3 4 5 6 3 chunks +6 lines, -6 lines 0 comments Download
ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
ui/views/widget/widget.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
ui/views/widget/widget.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
ui/views/widget/widget_hwnd_utils.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
win8/viewer/metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Ben Goodger (Google)
6 years, 10 months ago (2014-02-12 16:57:57 UTC) #1
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 10 months ago (2014-02-12 16:58:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/160573002/1
6 years, 10 months ago (2014-02-12 16:59:24 UTC) #3
sky
Rubber stamp LGTM
6 years, 10 months ago (2014-02-12 16:59:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 17:15:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=228546
6 years, 10 months ago (2014-02-12 17:15:49 UTC) #6
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 10 months ago (2014-02-13 20:59:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/160573002/470001
6 years, 10 months ago (2014-02-13 21:01:59 UTC) #8
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-14 06:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/160573002/820001
6 years, 10 months ago (2014-02-14 06:35:58 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 07:39:03 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-14 07:39:04 UTC) #12
Ben Goodger (Google)
6 years, 10 months ago (2014-02-14 18:55:35 UTC) #13
Message was sent while issue was closed. 
Committed patchset #9 manually as r251379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698