Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 16057020: suppress memory leak content::ShellBrowserMainParts::PreMainMessageLoopRun (Closed)

Created:
7 years, 6 months ago by zhaoqin
Modified:
7 years, 6 months ago
Reviewers:
awong
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

suppress memory leak content::ShellBrowserMainParts::PreMainMessageLoopRun TBR=ajwong@chromium.org BUG=245828 TEST=waterfall Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zhaoqin
7 years, 6 months ago (2013-06-03 21:18:20 UTC) #1
zhaoqin
Committed patchset #1 manually as r203772 (presubmit successful).
7 years, 6 months ago (2013-06-03 21:18:39 UTC) #2
awong
7 years, 6 months ago (2013-06-03 21:21:06 UTC) #3
LGTM




On Tue, Jun 4, 2013 at 5:18 AM, <zhaoqin@google.com> wrote:

> Reviewers: awong,
>
> Description:
> suppress memory leak content::**ShellBrowserMainParts::**
> PreMainMessageLoopRun
> TBR=ajwong@chromium.org
> BUG=245828
> TEST=waterfall
>
> Please review this at
https://codereview.chromium.**org/16057020/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M tools/valgrind/memcheck/**suppressions.txt
>
>
> Index: tools/valgrind/memcheck/**suppressions.txt
> diff --git a/tools/valgrind/memcheck/**suppressions.txt
> b/tools/valgrind/memcheck/**suppressions.txt
> index c7007160056f562825877e04d839e2**c0b7c3bcc5..**
> d955cd359aabcdf623a990a8437f56**28836ad3a5 100644
> --- a/tools/valgrind/memcheck/**suppressions.txt
> +++ b/tools/valgrind/memcheck/**suppressions.txt
> @@ -7308,7 +7308,7 @@ fun:_**ZN7content21RenderViewHostMana**
> ger8NavigateERKNS_**19NavigationEntryImplE
>     fun:_**ZN3IPC12ChannelProxy7Context15**OnChannelClosedEv
>  }
>  {
> -   bug_245828
> +   bug_245828a
>     Memcheck:Leak
>     fun:_Znw*
>     fun:_**ZN4base8internal20PostTaskAndR**eplyImpl16PostTaskAndReplyERKN*
> *15tracked_**objects8LocationERKNS_**8CallbackIFvvEEESA_
> @@ -7326,6 +7326,19 @@ fun:_**ZN7content21RenderViewHostMana**
> ger8NavigateERKNS_**19NavigationEntryImplE
>     fun:_**ZN7content11ContentMainEiPPKcP**NS_19ContentMainDelegateE
>  }
>  {
> +   bug_245828b
> +   Memcheck:Leak
> +   fun:_Znw*
> +   fun:_**ZN7content21ShellBrowserMainPa**rts21PreMainMessageLoopRunEv
> +   fun:_**ZN7content15BrowserMainLoop13C**reateThreadsEv
> +   fun:_**ZN7content21BrowserMainRunnerI**mpl10InitializeERKNS_**
> 18MainFunctionParamsE
> +   fun:_**Z16ShellBrowserMainRKN7content**18MainFunctionParamsE
> +   fun:_**ZN7content17ShellMainDelegate1**0RunProcessERKSsRKNS_**
> 18MainFunctionParamsE
> +   fun:_**ZN7content23RunNamedProcessTyp**eMainERKSsRKNS_**
> 18MainFunctionParamsEPNS_**19ContentMainDelegateE
> +   fun:_**ZN7content21ContentMainRunnerI**mpl3RunEv
> +   fun:_**ZN7content11ContentMainEiPPKcP**NS_19ContentMainDelegateE
> +}
> +{
>     bug_245866
>     Memcheck:Leak
>     fun:_Znw*
>
>
>

Powered by Google App Engine
This is Rietveld 408576698