Issue 16057005: Special Array constructor type feedback erroneously recorded when Array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16057005: Special Array constructor type feedback erroneously recorded when Array (Closed)

Created:
7 years, 6 months ago by mvstanton

Modified:
7 years, 6 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Special Array constructor type feedback erroneously recorded when Array was called as a function. Issue was found with optimize_constructed_array turned on. This patch makes the fix, and turns the flag back on. BUG=244461 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14917

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -36 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	test/mjsunit/allocation-site-info.js	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-244461.js	View	1 chunk	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Danno, here is the CL we talked about. Could you have a look? Thanks, ...

7 years, 6 months ago (2013-06-03 14:11:58 UTC) #1

mvstanton

7 years, 6 months ago (2013-06-03 14:46:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14917 (presubmit successful).

Expand Messages | Collapse Messages