ui/aura/root_window.cc - Issue 160563002: Aura: don't synthesize mouse moves while holding pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/root_window.cc

Issue 160563002: Aura: don't synthesize mouse moves while holding pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added check for synthetic event Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/aura/root_window.cc

diff --git a/ui/aura/root_window.cc b/ui/aura/root_window.cc

index 04ced914c62ad451637a4728e17e2ef8a20a384d..8733816bc5f57a1e0472ec7f7f5dc46ae3a22f34 100644

--- a/ui/aura/root_window.cc

+++ b/ui/aura/root_window.cc

@@ -791,6 +791,10 @@ void RootWindow::PreDispatchMouseEvent(Window* target,

if (IsEventCandidateForHold(*event) && !dispatching_held_event_) {

if (move_hold_count_) {

+ if (!(event->flags() & ui::EF_IS_SYNTHESIZED) &&

+ event->type() != ui::ET_MOUSE_CAPTURE_CHANGED) {

+ SetLastMouseLocation(window(), event->root_location());

+ }

held_move_event_.reset(new ui::MouseEvent(*event, target, window()));

event->SetHandled();

return;

« no previous file with comments | « no previous file | ui/aura/root_window_unittest.cc » ('j') | no next file with comments »