Aura: don't synthesize mouse moves while holding pointer.

ui/aura/root_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/root_window.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 812 matching lines @@
   client::CursorClient* cursor_client = client::GetCursorClient(window());
   if (cursor_client &&
       !cursor_client->IsMouseEventsEnabled() &&
       (event->flags() & ui::EF_IS_SYNTHESIZED)) {
     event->SetHandled();
     return;
   }
 
   if (IsEventCandidateForHold(*event) && !dispatching_held_event_) {
     if (move_hold_count_) {
+      if (event->type() != ui::ET_MOUSE_CAPTURE_CHANGED)

[sky, 2014/02/14 16:40:05]

I think you should be selective here. Meaning use equality rather than
inequality. The way you have it now you'll include ET_TOUCH_MOVED, which
shouldn't effect the mouse location.

[dgozman, 2014/02/17 14:19:59]

It's inside PreDispatchMouseEvent. The only mouse event we shouldn't update
location is ET_MOUSE_CAPTURE_CHANGED.
I've added check for synthetic event though.

+        SetLastMouseLocation(window(), event->root_location());
       held_move_event_.reset(new ui::MouseEvent(*event, target, window()));
       event->SetHandled();
       return;
     } else {
       // We may have a held event for a period between the time move_hold_count_
       // fell to 0 and the DispatchHeldEvents executes. Since we're going to
       // dispatch the new event directly below, we can reset the old one.
       held_move_event_.reset();
     }
   }
@@ skipping 98 matching lines @@
       break;
 
     default:
       NOTREACHED();
       break;
   }
   PreDispatchLocatedEvent(target, event);
 }
 
 }  // namespace aura