Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1605583002: Add tests for no context takeover configurations with multiple messages. (Closed)

Created:
4 years, 11 months ago by butlermatt
Modified:
4 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for no context takeover configurations with multiple messages. BUG= Patch by Matthew Butler <butler.matthew@gmail.com>; R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/c60c5a595d1088a64a2177e4fe86a84111e58045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M tests/standalone/io/web_socket_compression_test.dart View 3 chunks +63 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
butlermatt
Add tests for multiple messages with various no context takeover configurations per recommendation.
4 years, 11 months ago (2016-01-18 16:14:41 UTC) #2
Søren Gjesse
lgtm
4 years, 11 months ago (2016-01-22 12:34:40 UTC) #4
Søren Gjesse
4 years, 11 months ago (2016-01-22 12:36:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c60c5a595d1088a64a2177e4fe86a84111e58045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698