Remove MockConstraints

Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
Committed: https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553
Cr-Commit-Position: refs/heads/master@{#370219}

[hta - Chromium, 2016-01-18 12:21:42]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-18 12:21:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605513002/1

[commit-bot: I haz the power, 2016-01-18 13:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-18 13:13:16]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2016-01-18 13:15:29]

Description was changed from

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

to

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

[hta - Chromium, 2016-01-18 13:15:30]

hta@chromium.org changed reviewers:
+ tommi@chromium.org

[hta - Chromium, 2016-01-18 13:15:52]

I think this needs only your LGTM?

[hta - Chromium, 2016-01-18 13:24:05]

hta@chromium.org changed reviewers:
+ jochen@chromium.org

[hta - Chromium, 2016-01-18 13:24:22]

Need an owner LGTM.

[tommi (sloooow) - chröme, 2016-01-18 13:38:30]

lgtm

[jochen (gone - plz use gerrit), 2016-01-19 17:18:50]

lgtm

[hta - Chromium, 2016-01-19 22:07:24]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-01-19 22:09:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605513002/1

[commit-bot: I haz the power, 2016-01-19 23:19:05]

Description was changed from

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

to

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

[commit-bot: I haz the power, 2016-01-19 23:19:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-19 23:20:51]

Description was changed from

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997
==========

to

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997

Committed: https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553
Cr-Commit-Position: refs/heads/master@{#370219}
==========

[commit-bot: I haz the power, 2016-01-19 23:20:52]

Patchset 1 (id:??) landed as
https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553
Cr-Commit-Position: refs/heads/master@{#370219}

[samli, 2016-01-20 00:25:32]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1608073002/ by samli@chromium.org.

The reason for reverting is: Appears to be causing
fast/mediastream/RTCPeerConnection.html to fail across all bots..

[hta - Chromium, 2016-01-20 17:46:43]

Description was changed from

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997

Committed: https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553
Cr-Commit-Position: refs/heads/master@{#370219}
==========

to

==========
Remove MockConstraints

The purpose of the MockConstraints class was to verify that only legal
constraint names were passed. This is now done inside Blink
in MediaConstraintsImpl.cpp, so this class isn't needed any more.

BUG=543997

Committed: https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553
Cr-Commit-Position: refs/heads/master@{#370219}
==========

[hta - Chromium, 2016-01-20 20:58:22]

Reviewers, PTAL.

This has been rolled back because a test failed; I reopened the review and fixed
the issue. I hope this is the right way to re-land a rolled-back CL.

[kjellander_chromium, 2016-01-21 08:07:41]

On 2016/01/20 20:58:22, hta - Chromium wrote:
> Reviewers, PTAL.
> 
> This has been rolled back because a test failed; I reopened the review and
fixed
> the issue. I hope this is the right way to re-land a rolled-back CL.

I believe it's always suggested to re-land using a new CL. You can generate one
with the right CL description by reverting the revert CL (but don't put it into
the CQ since you want to add your fix to it first).
That way, it'll say it's a re-land, and you can upload a new patch set with the
fix, then review.

Re-using the same CL will be quite confusing (and old l-g-t-m's would be
reusable, which is not really the right thing to do since you'll want a new
look).

[chromium-reviews, 2016-01-21 08:27:04]

Kjellander, at the risk of asking obvious stuff (better than not learning):
what's the right way to create a rollback of a CL? There doesn't seem to be
a "git cl rollback" or "git cl patch --reverse".




On Thu, Jan 21, 2016 at 9:07 AM, <kjellander@chromium.org> wrote:

> On 2016/01/20 20:58:22, hta - Chromium wrote:
>
>> Reviewers, PTAL.
>>
>
> This has been rolled back because a test failed; I reopened the review and
>>
> fixed
>
>> the issue. I hope this is the right way to re-land a rolled-back CL.
>>
>
> I believe it's always suggested to re-land using a new CL. You can
> generate one
> with the right CL description by reverting the revert CL (but don't put it
> into
> the CQ since you want to add your fix to it first).
> That way, it'll say it's a re-land, and you can upload a new patch set
> with the
> fix, then review.
>
> Re-using the same CL will be quite confusing (and old l-g-t-m's would be
> reusable, which is not really the right thing to do since you'll want a new
> look).
>
> https://codereview.chromium.org/1605513002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tommi (sloooow) - chröme, 2016-01-21 08:39:06]

There's a 'revert' check box in rietveld that's easiest to use.

On Thu, Jan 21, 2016 at 9:27 AM Harald Alvestrand <hta@google.com> wrote:

> Kjellander, at the risk of asking obvious stuff (better than not learning):
> what's the right way to create a rollback of a CL? There doesn't seem to
> be a "git cl rollback" or "git cl patch --reverse".
>
>
>
>
> On Thu, Jan 21, 2016 at 9:07 AM, <kjellander@chromium.org> wrote:
>
>> On 2016/01/20 20:58:22, hta - Chromium wrote:
>>
>>> Reviewers, PTAL.
>>>
>>
>> This has been rolled back because a test failed; I reopened the review and
>>>
>> fixed
>>
>>> the issue. I hope this is the right way to re-land a rolled-back CL.
>>>
>>
>> I believe it's always suggested to re-land using a new CL. You can
>> generate one
>> with the right CL description by reverting the revert CL (but don't put
>> it into
>> the CQ since you want to add your fix to it first).
>> That way, it'll say it's a re-land, and you can upload a new patch set
>> with the
>> fix, then review.
>>
>> Re-using the same CL will be quite confusing (and old l-g-t-m's would be
>> reusable, which is not really the right thing to do since you'll want a
>> new
>> look).
>>
>> https://codereview.chromium.org/1605513002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hta - Chromium, 2016-01-21 09:05:01]

Reclosed issue and created reland CL here:

https://codereview.chromium.org/1614733002/