Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1605503002: Added tests for more preload as values (Closed)

Created:
4 years, 11 months ago by Yoav Weiss
Modified:
4 years, 11 months ago
Reviewers:
Nate Chapin, Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added tests for more preload as values The CL makes sure that all `as` types are properly handled and preloaded. It only adds tests, without any functional changes. BUG=471199 Committed: https://crrev.com/1b08ddc2f37a6463ee7edc3555cb5b1b4e0d71f9 Cr-Commit-Position: refs/heads/master@{#370096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/preload/download_resources.html View 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/single_download_preload.html View 2 chunks +14 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/resources/test.oga View Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
Yoav Weiss
Hey! This adds some tests that make sure exotic preload as types are also working ...
4 years, 11 months ago (2016-01-18 12:20:04 UTC) #2
Mike West
LGTM.
4 years, 11 months ago (2016-01-19 11:27:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605503002/1
4 years, 11 months ago (2016-01-19 11:29:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 11:34:52 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 11:36:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b08ddc2f37a6463ee7edc3555cb5b1b4e0d71f9
Cr-Commit-Position: refs/heads/master@{#370096}

Powered by Google App Engine
This is Rietveld 408576698