Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1605483002: Remove premature crankshaft optimization of HasInPrototypeChain. (Closed)

Created:
4 years, 11 months ago by neis
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove premature crankshaft optimization of HasInPrototypeChain. R=bmeurer@chromium.org BUG=chromium:578775 LOG=n Committed: https://crrev.com/107db2ca8c7411363657b69b1a4adf731e5f674d Cr-Commit-Position: refs/heads/master@{#33356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/js/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-578775.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 11 months ago (2016-01-18 11:04:27 UTC) #1
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-18 11:23:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605483002/1
4 years, 11 months ago (2016-01-18 11:44:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 12:11:57 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 12:12:39 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/107db2ca8c7411363657b69b1a4adf731e5f674d
Cr-Commit-Position: refs/heads/master@{#33356}

Powered by Google App Engine
This is Rietveld 408576698