components/content_settings/core/browser/host_content_settings_map.h - Issue 1605453003: Ensure content settings aren't persisted in the guest profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/host_content_settings_map.h

Issue 1605453003: Ensure content settings aren't persisted in the guest profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/cookie_settings_unittest.cc ('k') | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/host_content_settings_map.h

diff --git a/components/content_settings/core/browser/host_content_settings_map.h b/components/content_settings/core/browser/host_content_settings_map.h

index 0c12c48e05b2289690c5204aebe31ac818b154ea..b31228e5857f80b3d33f81e53f099aab86eea0b8 100644

--- a/components/content_settings/core/browser/host_content_settings_map.h

+++ b/components/content_settings/core/browser/host_content_settings_map.h

@@ -62,8 +62,11 @@ class HostContentSettingsMap : public content_settings::Observer,

};

// This should be called on the UI thread, otherwise |thread_checker_| handles

- // CalledOnValidThread() wrongly.

- HostContentSettingsMap(PrefService* prefs, bool incognito);

+ // CalledOnValidThread() wrongly. Only one (or neither) of

+ // |is_incognito_profile| and |is_guest_profile| should be true.

+ HostContentSettingsMap(PrefService* prefs,

+ bool is_incognito_profile,

+ bool is_guest_profile);

static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);