content/renderer/media/renderer_gpu_video_accelerator_factories.h - Issue 1605423002: Make 'kVideoImageTextureTarget' a list of texture targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_gpu_video_accelerator_factories.h

Issue 1605423002: Make 'kVideoImageTextureTarget' a list of texture targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/renderer/media/renderer_gpu_video_accelerator_factories.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_gpu_video_accelerator_factories.h

diff --git a/content/renderer/media/renderer_gpu_video_accelerator_factories.h b/content/renderer/media/renderer_gpu_video_accelerator_factories.h

index b9bdd149dd4840749d556274e623bd3198c81da6..21478695eba0e29e146fb70ff211cfdd5d9e0814 100644

--- a/content/renderer/media/renderer_gpu_video_accelerator_factories.h

+++ b/content/renderer/media/renderer_gpu_video_accelerator_factories.h

@@ -52,7 +52,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,

const scoped_refptr<ContextProviderCommandBuffer>& context_provider,

bool enable_gpu_memory_buffer_video_frames,

- unsigned image_texture_target,

+ std::vector<unsigned> image_texture_targets,

bool enable_video_accelerator);

// media::GpuVideoAcceleratorFactories implementation.

@@ -77,7 +77,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

gfx::BufferUsage usage) override;

bool ShouldUseGpuMemoryBuffersForVideoFrames() const override;

- unsigned ImageTextureTarget() override;

+ unsigned ImageTextureTarget(gfx::BufferFormat format) override;

media::VideoPixelFormat VideoFrameOutputFormat() override;

scoped_ptr<media::GpuVideoAcceleratorFactories::ScopedGLContextLock>

GetGLContextLock() override;

@@ -101,7 +101,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,

const scoped_refptr<ContextProviderCommandBuffer>& context_provider,

bool enable_gpu_memory_buffer_video_frames,

- unsigned image_texture_target,

+ std::vector<unsigned> image_texture_targets,

bool enable_video_accelerator);

bool CheckContextLost();

@@ -119,7 +119,7 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

// Whether gpu memory buffers should be used to hold video frames data.

bool enable_gpu_memory_buffer_video_frames_;

- const unsigned image_texture_target_;

+ const std::vector<unsigned> image_texture_targets_;

// Whether video acceleration encoding/decoding should be enabled.

const bool video_accelerator_enabled_;