media/renderers/gpu_video_accelerator_factories.h - Issue 1605423002: Make 'kVideoImageTextureTarget' a list of texture targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/gpu_video_accelerator_factories.h

Issue 1605423002: Make 'kVideoImageTextureTarget' a list of texture targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TEXTURE_2D for 420 biplanar. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/renderer/render_thread_impl.cc ('k') | media/renderers/mock_gpu_video_accelerator_factories.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/renderers/gpu_video_accelerator_factories.h

diff --git a/media/renderers/gpu_video_accelerator_factories.h b/media/renderers/gpu_video_accelerator_factories.h

index b1086453f6d9b1603af0e898b1dd31ffd5713744..6037ba65485ddc0ad8622fff8c2a8c2731a26073 100644

--- a/media/renderers/gpu_video_accelerator_factories.h

+++ b/media/renderers/gpu_video_accelerator_factories.h

@@ -87,7 +87,7 @@ class MEDIA_EXPORT GpuVideoAcceleratorFactories {

gfx::BufferUsage usage) = 0;

virtual bool ShouldUseGpuMemoryBuffersForVideoFrames() const = 0;

- virtual unsigned ImageTextureTarget() = 0;

+ virtual std::vector<unsigned> ImageTextureTargets() = 0;

reveman 2016/01/25 18:50:56 nit: "virtual unsigned ImageTextureTarget(gfx::Buf

Daniele Castagna 2016/01/25 20:49:01 Done.

// Pixel format of the hardware video frames created when GpuMemoryBuffers

// video frames are enabled.

virtual VideoPixelFormat VideoFrameOutputFormat() = 0;