content/browser/gpu/browser_gpu_memory_buffer_manager.cc - Issue 1605423002: Make 'kVideoImageTextureTarget' a list of texture targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/browser_gpu_memory_buffer_manager.cc

Issue 1605423002: Make 'kVideoImageTextureTarget' a list of texture targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TEXTURE_2D for 420 biplanar. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/gpu/browser_gpu_memory_buffer_manager.cc

diff --git a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc

index d9c25c9344bb68d8093ee2ac849a41dd27c81a3a..b33d01028c4b9b3a937f501c899833645c1e61ca 100644

--- a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc

+++ b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc

@@ -246,6 +246,8 @@ uint32_t BrowserGpuMemoryBufferManager::GetImageTextureTarget(

// require TEXTURE_EXTERNAL_OES.

return GL_TEXTURE_EXTERNAL_OES;

case gfx::IO_SURFACE_BUFFER:

+ if (format == gfx::BufferFormat::YUV_420_BIPLANAR)

reveman 2016/01/25 18:50:55 Remove this change as discussed.

Daniele Castagna 2016/01/25 20:49:01 Done.

+ return GL_TEXTURE_2D;

// IOSurface backed images require GL_TEXTURE_RECTANGLE_ARB.

return GL_TEXTURE_RECTANGLE_ARB;

case gfx::SHARED_MEMORY_BUFFER:

« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.cc » ('j') | content/browser/renderer_host/render_process_host_impl.cc » ('J')