Make 'kVideoImageTextureTarget' a list of texture targets.

Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG=524582
Committed: https://crrev.com/5077d6dc8037fdc2e19c70270083ec5b28e0fe89
Cr-Commit-Position: refs/heads/master@{#371644}

[Daniele Castagna, 2016-01-25 17:36:13]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-01-25 18:50:56]

lgtm with nits after removing the BGMBM change

https://codereview.chromium.org/1605423002/diff/40001/content/browser/gpu/bro...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1605423002/diff/40001/content/browser/gpu/bro...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:249: if (format ==
gfx::BufferFormat::YUV_420_BIPLANAR)
Remove this change as discussed.

https://codereview.chromium.org/1605423002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1605423002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:1258: // we are
actually going to use them.
nit: Can you add a TODO here for merging this with kVideoImageTextureTarget
below after removing GPU_READ_CPU_READ_WRITE_PERSISTENT?

https://codereview.chromium.org/1605423002/diff/40001/media/renderers/gpu_vid...
File media/renderers/gpu_video_accelerator_factories.h (right):

https://codereview.chromium.org/1605423002/diff/40001/media/renderers/gpu_vid...
media/renderers/gpu_video_accelerator_factories.h:90: virtual
std::vector<unsigned> ImageTextureTargets() = 0;
nit: "virtual unsigned ImageTextureTarget(gfx::BufferFormat format) = 0;"
instead to avoid copying the vector each time this is called?

[Daniele Castagna, 2016-01-25 20:49:00]

dcastagna@chromium.org changed reviewers:
+ avi@chromium.org, dalecurtis@chromium.org

[Daniele Castagna, 2016-01-25 20:49:01]

+avi for content/*
+dalecurtis for media/*

https://codereview.chromium.org/1605423002/diff/40001/content/browser/gpu/bro...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1605423002/diff/40001/content/browser/gpu/bro...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:249: if (format ==
gfx::BufferFormat::YUV_420_BIPLANAR)
On 2016/01/25 at 18:50:55, reveman wrote:
> Remove this change as discussed.

Done.

https://codereview.chromium.org/1605423002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1605423002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:1258: // we are
actually going to use them.
On 2016/01/25 at 18:50:56, reveman wrote:
> nit: Can you add a TODO here for merging this with kVideoImageTextureTarget
below after removing GPU_READ_CPU_READ_WRITE_PERSISTENT?

Done.

https://codereview.chromium.org/1605423002/diff/40001/media/renderers/gpu_vid...
File media/renderers/gpu_video_accelerator_factories.h (right):

https://codereview.chromium.org/1605423002/diff/40001/media/renderers/gpu_vid...
media/renderers/gpu_video_accelerator_factories.h:90: virtual
std::vector<unsigned> ImageTextureTargets() = 0;
On 2016/01/25 at 18:50:56, reveman wrote:
> nit: "virtual unsigned ImageTextureTarget(gfx::BufferFormat format) = 0;"
instead to avoid copying the vector each time this is called?

Done.

[DaleCurtis, 2016-01-25 21:51:32]

media/ lgtm -- any bug to associate with this?

[Daniele Castagna, 2016-01-25 22:43:36]

Description was changed from

==========
Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG=
==========

to

==========
Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG= 524582
==========

[Daniele Castagna, 2016-01-25 22:43:44]

Description was changed from

==========
Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG= 524582
==========

to

==========
Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG=524582
==========

[Daniele Castagna, 2016-01-26 21:21:23]

dcastagna@chromium.org changed reviewers:
+ sievers@chromium.org

[Daniele Castagna, 2016-01-26 21:21:23]

+sievers for content/*

[no sievers, 2016-01-26 23:07:18]

On 2016/01/26 21:21:23, Daniele Castagna wrote:
> +sievers for content/*

lgtm

[Daniele Castagna, 2016-01-26 23:08:54]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-01-26 23:08:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1605423002/#ps80001
(title: "Fix typo.")

[commit-bot: I haz the power, 2016-01-26 23:12:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605423002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605423002/80001

[commit-bot: I haz the power, 2016-01-27 00:07:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-27 00:08:13]

Description was changed from

==========
Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG=524582
==========

to

==========
Make 'kVideoImageTextureTarget' a list of texture targets.

Pass to the renderer a list of texture targets, one per GpuMemoryBuffer
format, via a command line argument.
In this way GMBVFP can pick whatever GMB format it needs to use and bind
to the correct texture target.
This is similar to what we do for content (kContentImageTextureTarget).

kContentImageTextureTarget can't be used since the buffer usage could
differ from the buffer usage in GMBVFP.

Once all GMB formats supports persistent usage and we can consolidate
GPU_READ_CPU_READ_WRITE_PERSISTENT and GPU_READ_CPU_READ_WRITE this
code can go away and we can use just one command line switch.

BUG=524582

Committed: https://crrev.com/5077d6dc8037fdc2e19c70270083ec5b28e0fe89
Cr-Commit-Position: refs/heads/master@{#371644}
==========

[commit-bot: I haz the power, 2016-01-27 00:08:14]

Patchset 5 (id:??) landed as
https://crrev.com/5077d6dc8037fdc2e19c70270083ec5b28e0fe89
Cr-Commit-Position: refs/heads/master@{#371644}