Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h

Issue 1605323004: Check if internal_format is valid for GenerateMipmap(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
diff --git a/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h b/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
index aeaecd068f2e86b5af89a2953c755ec67e92b162..2d0091f30165b3e8fcf1f93c60dc68c619e50ccc 100644
--- a/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
+++ b/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
@@ -1192,6 +1192,25 @@ static const GLenum valid_texture_parameter_table_es3[] = {
GL_TEXTURE_WRAP_R,
};
+static const GLenum
+ valid_texture_sized_color_renderable_internal_format_table[] = {
+ GL_R8, GL_R8UI, GL_R8I, GL_R16UI, GL_R16I,
+ GL_R32UI, GL_R32I, GL_RG8, GL_RG8UI, GL_RG8I,
+ GL_RG16UI, GL_RG16I, GL_RG32UI, GL_RG32I, GL_RGB8,
+ GL_RGB565, GL_RGBA8, GL_SRGB8_ALPHA8, GL_RGB5_A1, GL_RGBA4,
+ GL_RGB10_A2, GL_RGBA8UI, GL_RGBA8I, GL_RGB10_A2UI, GL_RGBA16UI,
+ GL_RGBA16I, GL_RGBA32UI, GL_RGBA32I,
+};
+
+static const GLenum
+ valid_texture_sized_texture_filterable_internal_format_table[] = {
+ GL_R8, GL_R8_SNORM, GL_R16F, GL_RG8,
+ GL_RG8_SNORM, GL_RG16F, GL_RGB8, GL_SRGB8,
+ GL_RGB565, GL_RGB8_SNORM, GL_R11F_G11F_B10F, GL_RGB9_E5,
+ GL_RGB16F, GL_RGBA8, GL_SRGB8_ALPHA8, GL_RGBA8_SNORM,
+ GL_RGB5_A1, GL_RGBA4, GL_RGB10_A2, GL_RGBA16F,
+};
+
static const GLenum valid_texture_target_table[] = {
GL_TEXTURE_2D,
GL_TEXTURE_CUBE_MAP_POSITIVE_X,
@@ -1202,6 +1221,10 @@ static const GLenum valid_texture_target_table[] = {
GL_TEXTURE_CUBE_MAP_NEGATIVE_Z,
};
+static const GLenum valid_texture_unsized_internal_format_table[] = {
+ GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, GL_RGBA,
+};
+
bool Validators::TextureUsageValidator::IsValid(const GLenum value) const {
switch (value) {
case GL_NONE:
@@ -1366,8 +1389,19 @@ Validators::Validators()
arraysize(valid_texture_internal_format_storage_table)),
texture_parameter(valid_texture_parameter_table,
arraysize(valid_texture_parameter_table)),
+ texture_sized_color_renderable_internal_format(
+ valid_texture_sized_color_renderable_internal_format_table,
+ arraysize(
+ valid_texture_sized_color_renderable_internal_format_table)),
+ texture_sized_texture_filterable_internal_format(
+ valid_texture_sized_texture_filterable_internal_format_table,
+ arraysize(
+ valid_texture_sized_texture_filterable_internal_format_table)),
texture_target(valid_texture_target_table,
arraysize(valid_texture_target_table)),
+ texture_unsized_internal_format(
+ valid_texture_unsized_internal_format_table,
+ arraysize(valid_texture_unsized_internal_format_table)),
transform_feedback_bind_target(
valid_transform_feedback_bind_target_table,
arraysize(valid_transform_feedback_bind_target_table)),
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_validation_autogen.h ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698