Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 16053005: Avoid removing destination during moving paragrahs (Closed)

Created:
7 years, 6 months ago by yosin_UTC9
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

This patch changes CompositeEditCommand::cleanupAfterDeletion(), which is called when moving paragraphs after deletion, not to remove destination node. BUG=121317 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153982

Patch Set 1 : 2013-06-12T13:36:12 #

Patch Set 2 : 2013-07-11T15:13:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
A LayoutTests/editing/inserting/insert-html-crash-01.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + LayoutTests/editing/inserting/insert-html-crash-01-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 4 chunks +10 lines, -8 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
7 years, 6 months ago (2013-06-12 05:18:15 UTC) #1
leviw_travelin_and_unemployed
lgtm. From description: This patch changes CompositeEditCommand::cleanupAfterDeletion(), which called during moving paragraph at deletion, not ...
7 years, 5 months ago (2013-07-11 04:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/16053005/6001
7 years, 5 months ago (2013-07-11 04:52:35 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/editing/inserting/insert-html-crash-01-expected.txt: While running svn copy LayoutTests/fast/forms/interactive-validation-crash-by-style-override-expected.txt LayoutTests/editing/inserting/insert-html-crash-01-expected.txt --config-dir /b/commit-queue/subversion_config --non-interactive ...
7 years, 5 months ago (2013-07-11 04:52:37 UTC) #4
yosin_UTC9
7 years, 5 months ago (2013-07-11 06:16:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r153982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698