ARC: Show virtual keyboard when necessary on text input type change events.

ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847

Committed: https://crrev.com/33790d393773aa73462d33d4e71584f95704e6ba
Cr-Commit-Position: refs/heads/master@{#371481}

[kinaba, 2016-01-25 08:39:28]

kinaba@chromium.org changed reviewers:
+ hidehiko@chromium.org

[kinaba, 2016-01-25 08:39:28]

PTAL: hidehiko

(sorry to bother you with many CLs; no need for hurry :))

[hidehiko, 2016-01-26 08:05:53]

https://codereview.chromium.org/1605273002/diff/40001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_bridge.cc (right):

https://codereview.chromium.org/1605273002/diff/40001/components/arc/ime/arc_...
components/arc/ime/arc_ime_bridge.cc:127: if (input_method->GetTextInputClient()
== this &&
IMHO, this should work, and practically cover most use cases. However, an ideal
solution would be wire show-/hide-IME events between ChromeOS and IMF in
Android.

So, how about submitting this as a short term solution (because this looks small
enough), and filing a bug for long term proper solution with TODO comments?

[kinaba, 2016-01-26 08:26:48]

Patchset #4 (id:60001) has been deleted

[kinaba, 2016-01-26 08:28:18]

Description was changed from

==========
ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is not yet a perfect handling of virtual keyboard control--for instance,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field. Still, the current CL is at least necessary
and provides basic functionality.

BUG=b/25865847
==========

to

==========
ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847
==========

[kinaba, 2016-01-26 08:28:59]

https://codereview.chromium.org/1605273002/diff/40001/components/arc/ime/arc_...
File components/arc/ime/arc_ime_bridge.cc (right):

https://codereview.chromium.org/1605273002/diff/40001/components/arc/ime/arc_...
components/arc/ime/arc_ime_bridge.cc:127: if (input_method->GetTextInputClient()
== this &&
On 2016/01/26 08:05:53, hidehiko wrote:
> IMHO, this should work, and practically cover most use cases. However, an
ideal
> solution would be wire show-/hide-IME events between ChromeOS and IMF in
> Android.
> 
> So, how about submitting this as a short term solution (because this looks
small
> enough), and filing a bug for long term proper solution with TODO comments?

You're right. Added the TODO comment as suggested.

[hidehiko, 2016-01-26 09:10:47]

lgtm

[kinaba, 2016-01-26 09:11:52]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2016-01-26 09:12:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605273002/80001

[commit-bot: I haz the power, 2016-01-26 09:33:40]

Description was changed from

==========
ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847
==========

to

==========
ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847
==========

[commit-bot: I haz the power, 2016-01-26 09:33:41]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-26 09:34:45]

Description was changed from

==========
ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847
==========

to

==========
ARC: Show virtual keyboard when necessary on text input type change events.

ShowImeIfNeeded() must be explicitly called to bring up the virtual keyboard
when the device is in touch mode.

This is a short-term solution covering only basic use cases. Notably,
it doesn't handle the case when the user dismissed the keyboard manually and
then re-clicked an ARC text field yet.

BUG=581282
BUG=b/25865847

Committed: https://crrev.com/33790d393773aa73462d33d4e71584f95704e6ba
Cr-Commit-Position: refs/heads/master@{#371481}
==========

[commit-bot: I haz the power, 2016-01-26 09:34:45]

Patchset 4 (id:??) landed as
https://crrev.com/33790d393773aa73462d33d4e71584f95704e6ba
Cr-Commit-Position: refs/heads/master@{#371481}