Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1605243002: Remove Metro mode avatar/profile switcher assets (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
Reviewers:
msw, oshima
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Metro mode avatar/profile switcher assets BUG=558054 Committed: https://crrev.com/327f4816de86c9408c8638e9c91add65424affd3 Cr-Commit-Position: refs/heads/master@{#370906}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unused header #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_avatar.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_bottom.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_bottom_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_bottom_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_center.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_bottom.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_bottom_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_bottom_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_center.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_top.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_top_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_top_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_bottom.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_bottom_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_bottom_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_center.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_top.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_top_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_top_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_top.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_top_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_top_right.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 2 chunks +0 lines, -12 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
tapted
msw: please review new_avatar_button.cc oshima: for chrome/app/theme (context: these are in the way of some ...
4 years, 11 months ago (2016-01-20 23:43:04 UTC) #2
oshima
lgtm
4 years, 11 months ago (2016-01-20 23:44:30 UTC) #3
msw
lgtm with a nit https://codereview.chromium.org/1605243002/diff/1/chrome/browser/ui/views/profiles/new_avatar_button.cc File chrome/browser/ui/views/profiles/new_avatar_button.cc (right): https://codereview.chromium.org/1605243002/diff/1/chrome/browser/ui/views/profiles/new_avatar_button.cc#newcode9 chrome/browser/ui/views/profiles/new_avatar_button.cc:9: #include "base/win/windows_version.h" nit: remove
4 years, 11 months ago (2016-01-21 18:18:01 UTC) #4
tapted
https://codereview.chromium.org/1605243002/diff/1/chrome/browser/ui/views/profiles/new_avatar_button.cc File chrome/browser/ui/views/profiles/new_avatar_button.cc (right): https://codereview.chromium.org/1605243002/diff/1/chrome/browser/ui/views/profiles/new_avatar_button.cc#newcode9 chrome/browser/ui/views/profiles/new_avatar_button.cc:9: #include "base/win/windows_version.h" On 2016/01/21 18:18:01, msw wrote: > nit: ...
4 years, 11 months ago (2016-01-22 04:49:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605243002/20001
4 years, 11 months ago (2016-01-22 04:50:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 04:55:11 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/327f4816de86c9408c8638e9c91add65424affd3 Cr-Commit-Position: refs/heads/master@{#370906}
4 years, 11 months ago (2016-01-22 04:56:24 UTC) #11
tapted
https://codereview.chromium.org/1605243002/diff/20001/chrome/browser/ui/views/profiles/new_avatar_button.cc File chrome/browser/ui/views/profiles/new_avatar_button.cc (left): https://codereview.chromium.org/1605243002/diff/20001/chrome/browser/ui/views/profiles/new_avatar_button.cc#oldcode84 chrome/browser/ui/views/profiles/new_avatar_button.cc:84: } else if (base::win::GetVersion() >= base::win::VERSION_WIN8 || Argh. This ...
4 years, 11 months ago (2016-01-25 21:23:25 UTC) #12
tapted
4 years, 11 months ago (2016-01-25 21:23:55 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1631973002/ by tapted@chromium.org.

The reason for reverting is: Broke Win10

BUG=581097.

Powered by Google App Engine
This is Rietveld 408576698