msw: please review new_avatar_button.cc oshima: for chrome/app/theme (context: these are in the way of some ...
4 years, 11 months ago
(2016-01-20 23:43:04 UTC)
#2
msw: please review new_avatar_button.cc
oshima: for chrome/app/theme
(context: these are in the way of some refactoring/cleanups I'm trying to do for
the toolkit-views browser frame on mac)
oshima
lgtm
4 years, 11 months ago
(2016-01-20 23:44:30 UTC)
#3
lgtm
msw
lgtm with a nit https://codereview.chromium.org/1605243002/diff/1/chrome/browser/ui/views/profiles/new_avatar_button.cc File chrome/browser/ui/views/profiles/new_avatar_button.cc (right): https://codereview.chromium.org/1605243002/diff/1/chrome/browser/ui/views/profiles/new_avatar_button.cc#newcode9 chrome/browser/ui/views/profiles/new_avatar_button.cc:9: #include "base/win/windows_version.h" nit: remove
4 years, 11 months ago
(2016-01-21 18:18:01 UTC)
#4
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605243002/20001
4 years, 11 months ago
(2016-01-22 04:50:00 UTC)
#8
Issue 1605243002: Remove Metro mode avatar/profile switcher assets
(Closed)
Created 4 years, 11 months ago by tapted
Modified 4 years, 11 months ago
Reviewers: msw, oshima
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 3