Don't share same name for js proxies cache.

Don't share same name for js proxies cache.

[sra1, 2014-02-13 04:27:25]

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
File sdk/lib/js/dart2js/js_dart2js.dart (right):

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:498: _defineProperty(jsFunction,
_DART_CLOSURE_PROPERTY_NAME, o);
I too am not sure if this path can be executed before _wrapToDart.
Justin?

If _DART_CLOSURE_PROPERTY_NAME can be, perhaps make it a getter that does the
init on first use.

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:541: int counter = JS("int",
'Object["_DART_INTEROP_COUNTER_"]||0');
Pull _DART_INTEROP_COUNTER out into variable that can be documented.

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:544: _DART_CLOSURE_PROPERTY_NAME =
"_\$dart_dartClosure$counter";
These strings should be interned (possibly as a separate CL)

[floitsch, 2014-02-13 16:26:56]

No tests yet.
@Stephen: you are working on tests for
https://codereview.chromium.org/155983004/. Will your approach also work for
this library?

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
File sdk/lib/js/dart2js/js_dart2js.dart (right):

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:498: _defineProperty(jsFunction,
_DART_CLOSURE_PROPERTY_NAME, o);
On 2014/02/13 04:27:26, sra1 wrote:
> I too am not sure if this path can be executed before _wrapToDart.
> Justin?
> 
> If _DART_CLOSURE_PROPERTY_NAME can be, perhaps make it a getter that does the
> init on first use.

Done.

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:541: int counter = JS("int",
'Object["_DART_INTEROP_COUNTER_"]||0');
On 2014/02/13 04:27:26, sra1 wrote:
> Pull _DART_INTEROP_COUNTER out into variable that can be documented.

Done.

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:544: _DART_CLOSURE_PROPERTY_NAME =
"_\$dart_dartClosure$counter";
On 2014/02/13 04:27:26, sra1 wrote:
> These strings should be interned (possibly as a separate CL)

Done.

[justinfagnani, 2014-02-13 16:39:21]

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
File sdk/lib/js/dart2js/js_dart2js.dart (right):

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:498: _defineProperty(jsFunction,
_DART_CLOSURE_PROPERTY_NAME, o);
On 2014/02/13 04:27:26, sra1 wrote:
> I too am not sure if this path can be executed before _wrapToDart.
> Justin?
> 
> If _DART_CLOSURE_PROPERTY_NAME can be, perhaps make it a getter that does the
> init on first use.

Not easily, since _wrapToDart is called in the context initializer, but I think
there is one case where we can get into the js->dart conversion without ever
accessing context:

f() {}
new JsFunction.withThis(f).apply(null, thisArg: f);

Which is also the only path that calls JsObject._fromJs directly without going
through _wrapToDart

[floitsch, 2014-02-13 16:46:52]

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
File sdk/lib/js/dart2js/js_dart2js.dart (right):

https://codereview.chromium.org/160523002/diff/1/sdk/lib/js/dart2js/js_dart2j...
sdk/lib/js/dart2js/js_dart2js.dart:498: _defineProperty(jsFunction,
_DART_CLOSURE_PROPERTY_NAME, o);
On 2014/02/13 16:39:22, justinfagnani wrote:
> On 2014/02/13 04:27:26, sra1 wrote:
> > I too am not sure if this path can be executed before _wrapToDart.
> > Justin?
> > 
> > If _DART_CLOSURE_PROPERTY_NAME can be, perhaps make it a getter that does
the
> > init on first use.
> 
> Not easily, since _wrapToDart is called in the context initializer, but I
think
> there is one case where we can get into the js->dart conversion without ever
> accessing context:
> 
> f() {}
> new JsFunction.withThis(f).apply(null, thisArg: f);
> 
> Which is also the only path that calls JsObject._fromJs directly without going
> through _wrapToDart

I just made it safe and clean for now.

[floitsch, 2014-02-14 17:10:05]

Superseded by Stephen's CL. (closed).