src/common/dwarf/dwarf2diehandler.cc - Issue 1605153004: unittests: fix -Wnarrowing build errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/common/dwarf/dwarf2diehandler.cc

Issue 1605153004: unittests: fix -Wnarrowing build errors (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: convert to uint8_t Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/common/dwarf/dwarf2diehandler.cc

diff --git a/src/common/dwarf/dwarf2diehandler.cc b/src/common/dwarf/dwarf2diehandler.cc

index 20c15fa9d10262d69a2b6daf65115a4c117f0427..5737005edebfb4e906b8e2ac088329c88562b632 100644

--- a/src/common/dwarf/dwarf2diehandler.cc

+++ b/src/common/dwarf/dwarf2diehandler.cc

@@ -167,7 +167,7 @@ void DIEDispatcher::ProcessAttributeReference(uint64 offset,

void DIEDispatcher::ProcessAttributeBuffer(uint64 offset,

enum DwarfAttribute attr,

enum DwarfForm form,

- const char* data,

+ const uint8_t *data,

uint64 len) {

HandlerStack &current = die_handlers_.top();

// This had better be an attribute of the DIE we were meant to handle.