Issue 1605153002: Stop copying deprecated ResourceRules.plist

Issue 1605153002: Stop copying deprecated ResourceRules.plist (Closed)

Created:
4 years, 11 months ago by justincohen

Modified:
4 years, 11 months ago

Reviewers:
Mark Mentovai, Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

Stop copying deprecated ResourceRules.plist It seems ResourceRules.plist is no longer necessary in codesign. BUG=577711 R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/6f83895e96220fab8d168022ab89c7ad03d396e9

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -32 lines)			Patch
	M	pylib/gyp/mac_tool.py	View		1 chunk	+6 lines, -30 lines	0 comments	Download
	M	pylib/gyp/xcode_emulation.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 10 (3 generated)

Nico

are there any tests that need updating? if not, should there be? If this is ...

4 years, 11 months ago (2016-01-19 21:08:33 UTC) #3

Mark Mentovai

Note that we do use resource rules in Chrome still, although none of that should ...

4 years, 11 months ago (2016-01-19 21:20:52 UTC) #5

justincohen

mark@ I get the warning "Warning: --resource-rules has been deprecated in Mac OS X >= ...

4 years, 11 months ago (2016-01-20 03:08:36 UTC) #6

Mark Mentovai

It has been deprecated and we may be seeing it, but we don’t care. We’ll ...

4 years, 11 months ago (2016-01-20 03:32:33 UTC) #7

justincohen

Understood. Since no one else is using 'CODE_SIGN_RESOURCE_RULES_PATH', this should be safe. Thanks!

4 years, 11 months ago (2016-01-20 03:41:38 UTC) #8

justincohen

4 years, 11 months ago (2016-01-20 19:31:19 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f83895e96220fab8d168022ab89c7ad03d396e9 (presubmit successful).