Issue 160515: valgrind: Add a suppression for a hunspell memory leak during the SpellCheckT...

Issue 160515: valgrind: Add a suppression for a hunspell memory leak during the SpellCheckT... (Closed)

Created:
11 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

valgrind: Add a suppression for a hunspell memory leak during the SpellCheckTest_GetAutoCorrectionWord_EN_US test. TBR=dank BUG=18254 TEST=Watch the valgrind bot turn green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22257

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not_the_right_dank

11 years, 4 months ago (2009-08-03 03:30:03 UTC) #2

LGTM.    (Although the lines after the test function itself in the suppress=
ion,

> + =A0fun:_ZN7testing4Test3RunEv
> + =A0fun:_ZN7testing8internal12TestInfoImpl3RunEv
> + =A0fun:_ZN7testing8internal12TestInfoImpl7RunTestEPNS_8TestInfoE
> + =A0fun:_ZN7testing8TestCase3RunEv
> + =A0fun:_ZN7testing8TestCase11RunTestCaseEPS0_
> + =A0fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
> + =A0fun:_ZN7testing8UnitTest3RunEv
> + =A0fun:main

probably should have been omitted, they're just boilerplate.)

On Sun, Aug 2, 2009 at 6:27 PM, <jhawkins@chromium.org> wrote:
>
> Reviewers: dank,
>
> Description:
> valgrind: Add a suppression for a hunspell memory leak during the
> SpellCheckTest_GetAutoCorrectionWord_EN_US test.
>
> TBR=3Ddank
> BUG=3D18254
> TEST=3DWatch the valgrind bot turn green.
>
> Please review this at http://codereview.chromium.org/160515
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- tools/valgrind/memcheck/suppressions.txt =A0 =A0(revision 22256)
> +++ tools/valgrind/memcheck/suppressions.txt =A0 =A0(working copy)
> @@ -955,7 +955,7 @@
> =A0 =A0fun:_ZN7WebCore8SVGNames4initEv
> =A0}
> =A0{
> - =A0crbug_18070
> + =A0bug_18070
> =A0 Memcheck:Leak
> =A0 ...
> =A0 fun:_ZN7Version20GetVersionFromStringERKSs
> @@ -977,3 +977,23 @@
> =A0 fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
> =A0 fun:_ZN7testing8UnitTest3RunEv
> =A0}
> +{
> + =A0bug_18254
> + =A0Memcheck:Leak
> + =A0fun:_Znaj
> + =A0fun:_ZN8AffixMgr10parse_fileEv
> + =A0fun:_ZN8AffixMgrC1EPN8hunspell11BDictReaderEPP7HashMgrPi
> + =A0fun:_ZN8HunspellC1EPKhj
> + =A0fun:_ZN12SpellChecker10InitializeEv
> +
> =A0fun:_ZN12SpellChecker14SpellCheckWordEPKwiPiS2_PSt6vectorISbIwSt11char=
_traitsIwESaIwEESaIS7_EE
> +
> =A0fun:_ZN12SpellChecker21GetAutoCorrectionWordERKSbIwSt11char_traitsIwES=
aIwEEPS3_
> + =A0fun:_ZN47SpellCheckTest_GetAutoCorrectionWord_EN_US_Test8TestBodyEv
> + =A0fun:_ZN7testing4Test3RunEv
> + =A0fun:_ZN7testing8internal12TestInfoImpl3RunEv
> + =A0fun:_ZN7testing8internal12TestInfoImpl7RunTestEPNS_8TestInfoE
> + =A0fun:_ZN7testing8TestCase3RunEv
> + =A0fun:_ZN7testing8TestCase11RunTestCaseEPS0_
> + =A0fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
> + =A0fun:_ZN7testing8UnitTest3RunEv
> + =A0fun:main
> +}
>
>
>

Expand Messages | Collapse Messages