src/IceInstX8664.cpp - Issue 1605103002: Subzero. X86. Refactors Address Mode formation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8664.cpp

Issue 1605103002: Subzero. X86. Refactors Address Mode formation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Minor changes. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8664.cpp

diff --git a/src/IceInstX8664.cpp b/src/IceInstX8664.cpp

index 0072c6b50385cb35ff52476013ef13686d7064ff..a7236a3f67cd6f9de5992f8692927db97e7b81e3 100644

--- a/src/IceInstX8664.cpp

+++ b/src/IceInstX8664.cpp

@@ -270,7 +270,9 @@ TargetX8664Traits::Address TargetX8664Traits::X86OperandMem::toAsmAddress(

const bool NeedSandboxing = Target->needSandboxing();

(void)NeedSandboxing;

assert(!NeedSandboxing || IsLeaAddr ||

- (getBase()->getRegNum() == Traits::RegisterSet::Reg_r15));

+ (getBase()->getRegNum() == Traits::RegisterSet::Reg_r15) ||

+ (getBase()->getRegNum() == Traits::RegisterSet::Reg_rsp) ||

+ (getBase()->getRegNum() == Traits::RegisterSet::Reg_rbp));

return X8664::Traits::Address(getEncodedGPR(getBase()->getRegNum()),

getEncodedGPR(getIndex()->getRegNum()),

X8664::Traits::ScaleFactor(getShift()), Disp,

« no previous file with comments | « no previous file | src/IceTargetLowering.h » ('j') | src/IceTargetLoweringX8664.cpp » ('J')