SkValue: improve SkFromValue<T> implementation

SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*);
Refactor template<> bool SkFromValue<SkMatrix>(const SkValue&, SkMatrix*);

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1605093003

Committed: https://skia.googlesource.com/skia/+/fac3d1b72547aa23842c16e6df27ea4c2b54867a

[mtklein_C, 2016-01-20 18:48:38]

Description was changed from

==========
SkValue: simulate a version bump on SkMatrix

This keeps the current format, which seems great to me, but pretends
that we started with a "v1" format that always encoded every field.

This is an experiment to see how a version bump would work.

BUG=skia:
==========

to

==========
SkValue: simulate a version bump on SkMatrix

This keeps the current format, which seems great to me, but pretends
that we started with a "v1" format that always encoded every field.

This is an experiment to see how a version bump would work.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-20 18:58:31]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 18:58:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605093003/40001

[mtklein_C, 2016-01-20 19:03:36]

mtklein@chromium.org changed reviewers:
+ halcanary@google.com

[commit-bot: I haz the power, 2016-01-20 19:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 19:10:35]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-01-20 20:16:43]

On 2016/01/20 at 19:10:35, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

why commit this?  We know we can do this.  No need to waste time with an
imaginary format.

[mtklein, 2016-01-20 20:24:01]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-20 20:24:01]

ptal

[mtklein, 2016-01-20 20:24:06]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 20:24:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605093003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605093003/60001

[commit-bot: I haz the power, 2016-01-20 20:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 20:41:46]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-01-20 21:17:15]

On 2016/01/20 at 20:41:46, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

++good

LGTM

[hal.canary, 2016-01-20 21:34:00]

Description was changed from

==========
SkValue: simulate a version bump on SkMatrix

This keeps the current format, which seems great to me, but pretends
that we started with a "v1" format that always encoded every field.

This is an experiment to see how a version bump would work.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*)
Refactor template<> bool SkFromValue<SkMatrix>(

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-01-20 21:34:20]

Description was changed from

==========
SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*)
Refactor template<> bool SkFromValue<SkMatrix>(

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*);
Refactor template<> bool SkFromValue<SkMatrix>(const SkValue&, SkMatrix*);

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-01-20 21:34:38]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-01-20 21:34:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605093003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605093003/60001

[commit-bot: I haz the power, 2016-01-20 21:35:24]

Description was changed from

==========
SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*);
Refactor template<> bool SkFromValue<SkMatrix>(const SkValue&, SkMatrix*);

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkValue: improve SkFromValue<T> implementation

Add template<> bool SkFromValue<float>(const SkValue&, float*);
Refactor template<> bool SkFromValue<SkMatrix>(const SkValue&, SkMatrix*);

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/fac3d1b72547aa23842c16e6df27ea4c2b54867a
==========

[commit-bot: I haz the power, 2016-01-20 21:35:24]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/fac3d1b72547aa23842c16e6df27ea4c2b54867a